openssh bugs - May 2019 - [Bug 3003] New: [PATCH] ssh-keygen does not print ASCII art fingerprint of knonw_hosts entry

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

            Bug ID: 3003
           Summary: [PATCH] ssh-keygen does not print ASCII art
                    fingerprint of knonw_hosts entry
           Product: Portable OpenSSH
           Version: 8.0p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh-keygen
          Assignee: unassigned-bugs at mindrot.org
          Reporter: blaubosch at gmail.com

Created attachment 3274
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3274&action=edit
patch against current CVS version

ssh-keygen -l -f keyfile prints the fingerprint of a public key.
Combining the -l switch with -v additionally prints the key's "ASCII
art" representation, which is visually easier to compare in case the
key's fingerprint needs to be verified manually.

ssh-keygen -F host can be used to search the known_hosts file for a
host's key and adding -l prints the key's fingerprint. But combining
the -l switch with -v to get the ASCII art representation does not work
in this context; the source code makes no attempt to generate or print
the ASCII art fingerprint of the knonw_hosts key. This seems to be a
bug.

Attached is a patch that should fix this (I just copied the ASCII art
printing code from fingerprint_one_key() function used by
do_fingerpint(), and added a missing NULL check that was present
there.)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

--- Comment #1 from Ville Sinisalo <blaubosch at gmail.com> ---
Created attachment 3275
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3275&action=edit
patch for man page

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

Ville Sinisalo <blaubosch at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3274|0                           |1
        is obsolete|                            |
   Attachment #3275|0                           |1
        is obsolete|                            |

--- Comment #2 from Ville Sinisalo <blaubosch at gmail.com> ---
Created attachment 3276
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3276&action=edit
corrected patch for both ssh-keygen.c & man page

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3276|0                           |1
        is obsolete|                            |
             Status|NEW                         |ASSIGNED
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at dtucker.net
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
   Attachment #3289|                            |ok?(dtucker at dtucker.net)
              Flags|                            |

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Created attachment 3289
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3289&action=edit
tweak for style(9)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2988


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2988
[Bug 2988] Tracking bug for 8.1 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Applied - thanks

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Close bugs fixed in openssh-8.1 release cycle

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3003

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3289|ok?(dtucker at dtucker.net)    |
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.