openssh bugs - Jan 2019 - [Bug 2952] New: GSSAPI doesn't cleanup methoddata (leaks some memory).

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

            Bug ID: 2952
           Summary: GSSAPI doesn't cleanup methoddata (leaks some memory).
           Product: Portable OpenSSH
           Version: 7.9p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Kerberos support
          Assignee: unassigned-bugs at mindrot.org
          Reporter: markus at blueflash.cc

userauth_gssapi allocates a bit of memory for the authctxt->methoddata
pointer but doesn't clean up.

Side issue: userauth_gssapi is also using two function-static
variables.  One of these leaks.  The other one makes prevents
reusability (e.g. porting to OO languages) because there is no way to
reset it.  They should be moved to authctxt.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

--- Comment #1 from Markus <markus at blueflash.cc> ---

Another side issue: some gssapi-userauth related functions could be
made static and there is a function prototype (input_gssapi_hash) that
is no longer used.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

--- Comment #2 from Markus <markus at blueflash.cc> ---
Created attachment 3221
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3221&action=edit
patch to fix memory leak and side issues.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

--- Comment #3 from Markus <markus at blueflash.cc> ---
The initial patch now breaks after other patches (old packet api) were
applied to v7.9.

I'm attaching a new patch.  

It also slightly changes the pubkey_cleanup, adding it to the method
table as a cleanup handler, rather than calling it explicitely.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

Markus <markus at blueflash.cc> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3221|0                           |1
        is obsolete|                            |
                 CC|                            |markus at blueflash.cc

--- Comment #4 from Markus <markus at blueflash.cc> ---
Created attachment 3234
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3234&action=edit
Fixed patch for v7.9 after opacket removal


applies again to current v7.9 (portable)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net
             Blocks|                            |2915

--- Comment #5 from Darren Tucker <dtucker at dtucker.net> ---
Put on list for 8.0


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2915
[Bug 2915] Tracking bug for 8.0 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
   Attachment #3234|0                           |1
           is patch|                            |
   Attachment #3234|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
This has been committed and will be in the 8.0 release - thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2952

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
Move resolved bugs -> CLOSED after 8.0 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.