bugzilla-daemon at bugzilla.mindrot.org
2017-Dec-19 18:38 UTC
[Bug 2814] New: Connection error should report failure instead of success
https://bugzilla.mindrot.org/show_bug.cgi?id=2814
Bug ID: 2814
Summary: Connection error should report failure instead of
success
Product: Portable OpenSSH
Version: 7.6p1
Hardware: All
OS: Linux
Status: NEW
Severity: minor
Priority: P5
Component: ssh
Assignee: unassigned-bugs at mindrot.org
Reporter: mvrmanning at gmail.com
Created attachment 3106
--> https://bugzilla.mindrot.org/attachment.cgi?id=3106&action=edit
Suggested diff
When the connection fails, the error handling reports success if no
errno
was provided, as this defaults to 0 (Success). As this can never be the
case when an error occurs, instead the output should show a failure.
Forced example:
ssh -6 -b 10.0.0.3 vyatta at 2000::4
getaddrinfo: 10.0.0.3: Address family for hostname not supported
ssh: connect to host 2000::4 port 22: Success
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2018-Jan-05 02:27 UTC
[Bug 2814] Connection error should report failure instead of success
https://bugzilla.mindrot.org/show_bug.cgi?id=2814
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3106|0 |1
is obsolete| |
Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
CC| |djm at mindrot.org
Status|NEW |ASSIGNED
Attachment #3108| |ok?
Flags| |
--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 3108
--> https://bugzilla.mindrot.org/attachment.cgi?id=3108&action=edit
revised diff
Try a bit harder to preserve errno, but print something less wrong if
errno==0
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2018-Jan-05 02:53 UTC
[Bug 2814] Connection error should report failure instead of success
https://bugzilla.mindrot.org/show_bug.cgi?id=2814
Darren Tucker <dtucker at dtucker.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtucker at dtucker.net
Attachment #3108|ok? |ok+
Flags| |
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2018-Feb-23 02:45 UTC
[Bug 2814] Connection error should report failure instead of success
https://bugzilla.mindrot.org/show_bug.cgi?id=2814
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Blocks| |2782
--- Comment #2 from Damien Miller <djm at mindrot.org> ---
oops, I committed this a while back:
commit 7c77991f5de5d8475cbeb7cbb06d0c7d1611d7bb
Author: djm at openbsd.org <djm at openbsd.org>
Date: Tue Jan 23 05:17:04 2018 +0000
upstream commit
try harder to preserve errno during
ssh_connect_direct() to make the final error message possibly
accurate;
bz#2814, ok dtucker@
OpenBSD-Commit-ID: 57de882cb47381c319b04499fef845dd0c2b46ca
Referenced Bugs:
https://bugzilla.mindrot.org/show_bug.cgi?id=2782
[Bug 2782] Tracking bug for OpenSSH 7.7 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2018-Apr-06 02:26 UTC
[Bug 2814] Connection error should report failure instead of success
https://bugzilla.mindrot.org/show_bug.cgi?id=2814
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after release of OpenSSH 7.7.
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.