openssh bugs - Nov 2017 - [Bug 2801] New: RemoteCommand: Please allocate TTY, allow overriding command

https://bugzilla.mindrot.org/show_bug.cgi?id=2801

            Bug ID: 2801
           Summary: RemoteCommand: Please allocate TTY, allow overriding
                    command
           Product: Portable OpenSSH
           Version: 7.6p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: main.haarp at gmail.com

Created attachment 3097
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3097&action=edit
Allocate TTY, allow overriding command

Thank you for merging RemoteCommand.

I have two feature requests on top of it.

1. When specifying a command line to ssh while RemoteCommand is active,
openssh aborts with:

"Cannot execute command-line and remote command."

I think it would be much better to have a specified command line
override RemoteCommand instead. Otherwise it becomes a pain having it
active in your config.


2. When using RemoteCommand, no TTY is allocated by default, which
makes having shells in RemoteCommand very inconvenient.



I have attached a trivial patch taking care of both.

Also see comment 9 of bug 2103
(https://bugzilla.mindrot.org/show_bug.cgi?id=2103#c9).


Thanks!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2801

Daniel Black <daniel at linux.vnet.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel at linux.vnet.ibm.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2801

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Regarding #2 - does RequestTTY=yes not solve this problem?

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2801

--- Comment #2 from main.haarp at gmail.com ---
(In reply to Damien Miller from comment #1)
> Regarding #2 - does RequestTTY=yes not solve this problem?
Yes, but then RequestTTY must accompany RemoteCommand in every config
entry. This isn't always desirable, for example when using a
command-line (which is what request 1 in this bug is about).

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2801

Luiz Angelo Daros de Luca <luizluca at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luizluca at gmail.com

--- Comment #3 from Luiz Angelo Daros de Luca <luizluca at gmail.com> ---
The TTY allocation is a minor problem. However, the lack of precedence
of cmdline command is a much more complex issue. Users have to use ugly
hacks like
https://unix.stackexchange.com/questions/451253/how-to-configure-ssh-with-a-remotecommand-only-for-interactive-sessions-i-e-wi

Please, fix this.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2801

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
I don't think we should change the precedence, but maybe we could add a
"Match command ..." to allow users to specify a RemoteCommand only for
cases where none was entered on the commandline.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.