bugzilla-daemon at bugzilla.mindrot.org
2017-Oct-06 01:22 UTC
[Bug 2790] New: parameter ssh of function ssh channel_clear_permitted_opens could be NULL
https://bugzilla.mindrot.org/show_bug.cgi?id=2790
Bug ID: 2790
Summary: parameter ssh of function ssh
channel_clear_permitted_opens could be NULL
Product: Portable OpenSSH
Version: 7.6p1
Hardware: Other
OS: Other
Status: NEW
Severity: critical
Priority: P5
Component: Miscellaneous
Assignee: unassigned-bugs at mindrot.org
Reporter: yawang at microsoft.com
key base auth fail on windows because parameter ssh ssh-agent on
windows is null and the demon crashes. ssh-agent does not call
auth_clear_options but it does not need to call packet_set_connection.
void
channel_clear_permitted_opens(struct ssh *ssh)
{
struct ssh_channels *sc = ssh->chanctxt;
sc->permitted_opens = xrecallocarray(sc->permitted_opens,
sc->num_permitted_opens, 0, sizeof(*sc->permitted_opens));
sc->num_permitted_opens = 0;
}
Please add parameter check.
if(ssh == NULL)
return;
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Oct-23 01:21 UTC
[Bug 2790] parameter ssh of function ssh channel_clear_permitted_opens could be NULL
https://bugzilla.mindrot.org/show_bug.cgi?id=2790
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |djm at mindrot.org
--- Comment #1 from Damien Miller <djm at mindrot.org> ---
This call is nonsensical with a NULL argument. How does the Windows
port end up attempting it?
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2018-Jan-29 19:42 UTC
[Bug 2790] parameter ssh of function ssh channel_clear_permitted_opens could be NULL
https://bugzilla.mindrot.org/show_bug.cgi?id=2790
bingbing8 <yawang at microsoft.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2018-Jan-29 19:42 UTC
[Bug 2790] parameter ssh of function ssh channel_clear_permitted_opens could be NULL
https://bugzilla.mindrot.org/show_bug.cgi?id=2790
bingbing8 <yawang at microsoft.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.