openssh bugs - Sep 2017 - [Bug 2783] New: Patch for disabling progress meter after file has finished uploading

https://bugzilla.mindrot.org/show_bug.cgi?id=2783

            Bug ID: 2783
           Summary: Patch for disabling progress meter after file has
                    finished uploading
           Product: Portable OpenSSH
           Version: 7.6p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: scp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: gyroninja at tfwno.gf

Created attachment 3058
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3058&action=edit
patch that fixes issue

Once the file has finished uploading the progress meter stops updating.
Without this patch after the file has finished uploading the total time
value is bigger than it should be. This time being wrong also causes
your average upload rate to be incorrect since the timer is
incrementing without any data being sent.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2783

gyroninja at tfwno.gf changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3058|0                           |1
        is obsolete|                            |

--- Comment #1 from gyroninja at tfwno.gf ---
Created attachment 3059
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3059&action=edit
patch that fixes issue

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2783

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 3059
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3059
patch that fixes issue

This bug report doesn't make any sense: version 7.6p1 isn't released
yet and progressmeter.c doesn't contain the code you're modifying:
>-	if (cur_pos < end_pos) {
>-		signal(SIGALRM, update_progress_meter);
>-		alarm(UPDATE_INTERVAL);
>-		errno = save_errno;
>-	}
>+	signal(SIGALRM, update_progress_meter);
>+	alarm(UPDATE_INTERVAL);
>+	errno = save_errno;
The existing code already reads as after your patch is applied:

   241          if (can_output())
   242                  refresh_progress_meter();
   243  
   244          signal(SIGALRM, update_progress_meter);
   245          alarm(UPDATE_INTERVAL);
   246          errno = save_errno;

Generally though, apparent "hangs" at 100% of the progress meter
display are caused by buffering happening in the sending system ssh
process, kernel socket buffers, the network or at the receiving side.
Stopping the clock until the remote end has acknowledged receipt of the
entire file is *correcting* the time and bandwidth calculations that
are being distorted by the aforementioned buffering.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2783

gyroninja at tfwno.gf changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3059|0                           |1
        is obsolete|                            |

--- Comment #3 from gyroninja at tfwno.gf ---
Created attachment 3060
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3060&action=edit
patch that fixes issue

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2783

--- Comment #4 from gyroninja at tfwno.gf ---
Hi, sorry for making a few mistake. This is my first time contributing
to the project.
This change was originally for 7.4p1, but it didn't look like
progressmeter.c had changed since then so I selected the latest
version.
It looks like I accidentally had my diff backwards. I have corrected
the attachment with the diff in the right order.
The diff is supposed to insert the if, because the progress bar should
not update after it has finished transferring the whole file.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2783

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |djm at mindrot.org
         Resolution|---                         |FIXED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
I think these problems (and others) were fixed in the progressmeter.c
changes that Darren committed before the OpenSSH 8.0 release. Please
reopen the bug if this is not the case.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2783

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.