openssh bugs - Aug 2017 - [Bug 2767] New: Missing includes in bsd-err.c

https://bugzilla.mindrot.org/show_bug.cgi?id=2767

            Bug ID: 2767
           Summary: Missing includes in bsd-err.c
           Product: Portable OpenSSH
           Version: -current
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Miscellaneous
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cjwatson at debian.org

Created attachment 3040
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3040&action=edit
Add missing includes to openbsd-compat/bsd-err.c

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare
-Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign
-Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv
-fno-builtin-memset -fstack-protector-strong -fPIE  -I. -I.. -I. -I./..
 -DHAVE_CONFIG_H -c bsd-err.c
bsd-err.c: In function ?err?:
bsd-err.c:37:26: warning: implicit declaration of function ?strerror?;
did you mean ?hstrerror?? [-Wimplicit-function-declaration]
  fprintf(stderr, "%s: ", strerror(errno));
                          ^~~~~~~~
                          hstrerror
bsd-err.c:37:20: warning: format ?%s? expects argument of type ?char
*?, but argument 3 has type ?int? [-Wformat=]
  fprintf(stderr, "%s: ", strerror(errno));
                   ~^     ~~~~~~~~~~~~~~~
                   %d
bsd-err.c: In function ?warn?:
bsd-err.c:66:20: warning: format ?%s? expects argument of type ?char
*?, but argument 3 has type ?int? [-Wformat=]
  fprintf(stderr, "%s: ", strerror(errno));
                   ~^     ~~~~~~~~~~~~~~~
                   %d

I went through and added all the missing #includes in the attached
patch.  Some duplicate "includes.h", but it seems to be reasonably
common practice in OpenSSH to add direct #includes for symbols that are
used directly.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2767

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Blocks|                            |2698
                 CC|                            |dtucker at zip.com.au
             Status|NEW                         |RESOLVED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
(In reply to Colin Watson from comment #0)
> Created attachment 3040 [details]
> Add missing includes to openbsd-compat/bsd-err.c
Applied, thanks.
> I went through and added all the missing #includes in the attached
> patch.  Some duplicate "includes.h", but it seems to be
reasonably
> common practice in OpenSSH to add direct #includes for symbols that
> are used directly.
Current policy is to include system headers in the .c file where
they're needed however some of the compat code either needs it earlier,
was added prior to the policy or both.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2698
[Bug 2698] Tracking bug for OpenSSH 7.6 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2767

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after release of OpenSSH 7.7.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.