openssh bugs - Jan 2017 - [Bug 2658] New: Make integrity tests more robust against timeouts

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

            Bug ID: 2658
           Summary: Make integrity tests more robust against timeouts
           Product: Portable OpenSSH
           Version: 7.4p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Regression tests
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cjwatson at debian.org

Created attachment 2924
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2924&action=edit
Make integrity tests more robust against timeouts

If the first test in a series for a given MAC happens to modify the low
bytes of a packet length, then ssh will time out and this will be
interpreted as a test failure.  I'm seeing this in practice on Ubuntu
ppc64el (e.g.
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-zesty/zesty/ppc64el/o/openssh/20161231_121729_ebc8a@/log.gz).

Fortunately there was already an XXX comment indicating what might be
going wrong here, and although I haven't been able to reproduce it
directly on a system where I can experiment interactively, I can at
least reproduce it by fiddling with the start offset, which was enough
to be able to put together a patch to make the tests more robust.  That
patch is attached.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2647
                 CC|                            |dtucker at zip.com.au


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2647
[Bug 2647] Tracking bug for OpenSSH 7.5 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
Applied, thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

Colin Watson <cjwatson at debian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #2 from Colin Watson <cjwatson at debian.org> ---
Only part of this patch was actually applied (compare
https://bugzilla.mindrot.org/attachment.cgi?id=2924&action=diff with
https://anongit.mindrot.org/openssh.git/commit/?id=e5c7ec67cdc42ae2584085e0fc5cc5ee91133cf5).
 Could you please check again?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2698

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
will take a look


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2698
[Bug 2698] Tracking bug for OpenSSH 7.6 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
   Attachment #2924|                            |ok+
              Flags|                            |

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 2924
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2924
Make integrity tests more robust against timeouts

Looks ok to me

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> ---
Sorry about that; there were unnoticed rejects due to differences
between -portable and upstream.  I've resynced and applied the missing
part of the patch, it should all be there now:

https://anongit.mindrot.org/openssh.git/commit/?id=9504ea6b27f9f0ece64e88582ebb9235e664a100

Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.