openssh bugs - Nov 2015 - [Bug 2507] New: missing or misleading error messages

https://bugzilla.mindrot.org/show_bug.cgi?id=2507

            Bug ID: 2507
           Summary: missing or misleading error messages
           Product: Portable OpenSSH
           Version: 7.1p1
          Hardware: Sparc
                OS: Solaris
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: tomas.kuthan at oracle.com

After code refactoring for library-like interfaces, error messages are
no longer printed for DSA_do_sign() or RSA_sign() failures in some code
paths.

When investigating error messaging for signing failures I also noticed,
that incorrect messages are printed for sshkey_from_blob() and
sshkey_sign() errors in ssh-agent.c.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2507

--- Comment #1 from Tomas Kuthan <tomas.kuthan at oracle.com> ---
Created attachment 2758
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2758&action=edit
Call error() on identity_sign() failure, fix typos in ssherr() calls.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2507

flavio.gallucci at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |flavio.gallucci at gmail.com

--- Comment #2 from flavio.gallucci at gmail.com ---
openssh 6x doesn't give this problem.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2507

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |djm at mindrot.org
             Blocks|                            |2451

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Patch applied - thanks. This will be in the OpenSSH 7.2 release.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2451
[Bug 2451] Bugs intended to be fixed in 7.2
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2507

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.