openssh bugs - Sep 2015 - [Bug 2455] New: Regression tests tweaks: keyscan and hostkey_rotation

https://bugzilla.mindrot.org/show_bug.cgi?id=2455

            Bug ID: 2455
           Summary: Regression tests tweaks: keyscan and hostkey_rotation
           Product: Portable OpenSSH
           Version: 7.1p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Regression tests
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jjelen at redhat.com

Created attachment 2691
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2691&action=edit
fix regress/hostkey_rotation.s

During the walk through the regression test suite I hit few issues that
should be fixed. Namely:

 1) hostkey_rotation.sh contains some "mess" in the end of file,
probably created as a skeleton for the test that was not used in the
end (see patch)

 2) keyscan.sh doesn't scan for ecdsa keys (nor for ed25519). All the
other tests are now updated to reflect result of `ssh -Q key-plain`, or
use the list imported from test-exec.sh, except this one. But
sufficient would be to use just the list that is mentioned in manual
page (?dsa?, ?ecdsa?, ?ed25519?, ?rsa?).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2455

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |2451

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
The attached patch looks like it was made from the wrong files - it's
for an Include option and doesn't contain any keyscan.sh bits. 

I've committed the hostkey-rotate.sh parts, thanks.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2451
[Bug 2451] Bugs intended to be fixed in 7.2
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2455

Jakub Jelen <jjelen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2691|fix                         |fix
        description|regress/hostkey_rotation.s  |regress/hostkey_rotate.s
   Attachment #2691|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2455

--- Comment #2 from Jakub Jelen <jjelen at redhat.com> ---
Yay. Sorry for mistake. I am working on more things at once again.

But the first part in regress/hostkey-rotate.sh was understood well,
the second part was not included in the patch, because I am not sure
what is correct solution:

Current version:
> KEYTYPES="rsa dsa"
> if ssh_version 1; then
>     KEYTYPES="${KEYTYPES} rsa1"
> fi

Documentation notes this list should work:
> (?dsa?, ?ecdsa?, ?ed25519?, ?rsa?)
But it works well also for all the results from `ssh -Q key-plain`, as
can be found in other test cases:
> KEYTYPES=`ssh -Q key-plain`
Anyway, the key-plain argument is missing in manual page for ssh so it
would be great to add it.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2455

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Fixed (used ssh -Q key-plain and tweaked the manual) - thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2455

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.