openssh bugs - Jul 2015 - [Bug 2424] New: Compatibility for iSSH and Ubuntu/Mint Putty

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

            Bug ID: 2424
           Summary: Compatibility for iSSH and Ubuntu/Mint Putty
           Product: Portable OpenSSH
           Version: 6.9p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jrouman at gmail.com

Please consider adding "PuTTY_Local*" to the PuTTY versions allowed to
use SSH_OLD_DHGEX in compat.c.  This is the ID for iSSH and the PuTTY
distributed with Ubuntu and Mint Linux.  Sadly, iSSH is no longer being
maintained so a fix on that end is unlikely.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
I did actually consider doing that when I implemented the change.

I decided against it because it means that modern development versions
of PuTTY would also be impacted, and I'd rather new PuTTYs work with as
much of OpenSSH as possible, even if that means older development
snapshots.

Looking at it again, my putty git tree identifies itself as
SSH-2.0-PuTTY_Unidentified_Local_Build not PuTTY_Local.*.  Is the
latter identifier used for versions built from development trees or
something else?

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

--- Comment #2 from Jay Rouman <jrouman at gmail.com> ---
iSSH is an Apple iOS app that is built on some version of Putty.  The
developer has moved on but it is still available in the App Store for
people who have already purchased it.

It identifies to ssh as:

debug1: Client protocol version 2.0; client software version
PuTTY_Local:_Oct_19_2013_01:34:44


When you type "apt-get install putty" in Mint, you get a version of
Putty that says "Unidentified build, June 23, 2015 11:44:03" and
identifies to ssh as:

debug1: Client protocol version 2.0; client software version
PuTTY_Local:_Jun_23_2015_11:44:03

I don't know anything about how these version of Putty were created.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
I've checked with the PuTTY folks and according to Simon Tatham,
PuTTY_Local.* "was a prefix used in the old versioning system,
before I reworked it all prior to our migration from svn to git (as of
r10262, aka 4d8782e74fed043fdf549718f99494622fe9e79b)" in September
2014 and that it is probably safe to assume any client using it doesn't
do RFC4419 DH-GEX.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned-bugs at mindrot.org |dtucker at zip.com.au

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2662
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2662&action=edit
Add old PuTTY dev versions to the DH-GEX blacklist.

Please try this patch and let me know if it works.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

--- Comment #5 from Jay Rouman <jrouman at gmail.com> ---
Created attachment 2663
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2663&action=edit
iSSH compatibility patch

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

--- Comment #6 from Jay Rouman <jrouman at gmail.com> ---
I am traveling and don't have access to a test machine but your patch
is essentially what works on iSSH for me.  I have attached my patch
which I probably should have included originally.  I am sure what you
did will work fine.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2403
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Darren Tucker <dtucker at zip.com.au> ---
Patch committed and will be in the 7.0 release.  Thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2424

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.