openssh bugs - Jun 2015 - [Bug 2416] New: [PATCH] Allow forwarding of stdio to streamlocal end points

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

            Bug ID: 2416
           Summary: [PATCH] Allow forwarding of stdio to streamlocal end
                    points
           Product: Portable OpenSSH
           Version: -current
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: sfandino at yahoo.com

Created attachment 2654
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2654&action=edit
the patch

Later versions of OpenSSH allow the user to forward connections also
to/from Unix sockets.

This patch allows to use Unix sockets as the target when forwarding the
local stdio using the -W feature.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

Salvador Fandi?o <sfandino at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Linux                       |All
           Hardware|Other                       |All

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

--- Comment #1 from Salvador Fandi?o <sfandino at yahoo.com> ---
Some comments about the patch before I forget about them:

The same variables that were hosting the hostname now also can host the
socket path. The magic port number PORT_STREAMLOCAL (-2) is used to
indicate that it is a socket path.

I have to promote a couple of function argument from u_short to u_int
to let the PORT_STREAMLOCAL pass unmangled (as
(u_short)PORT_STREAMLOCAL results in a valid TCP port number).

I have done a s/host/path/ in some variable names. That's consistent
with the naming of the hostname/path slot in the Channel structure.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
   Attachment #2654|application/text            |text/plain
          mime type|                            |
   Attachment #2654|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
Comment on attachment 2654
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2654
the patch
>-channel_connect_stdio_fwd(const char *host_to_connect, u_short
port_to_connect,
>+channel_connect_stdio_fwd(const char *path_to_connect, u_int
port_to_connect,
any reason to keep port_to_connect as unsigned?  PORT_STREAMLOCAL is
negative and a signed int can cover that as well as the entire port
range without casts.

Also, I think I'd rather not rename host_to_connect: path_to_connect
isn't correct for the common case either and it makes the change a long
more invasive.

Still looking at rest of patch.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2654|0                           |1
        is obsolete|                            |
                 CC|                            |dtucker at zip.com.au

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2675
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2675&action=edit
revised streamlocal -W patch

Revised patch as per comments.  Currently untested.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2675|0                           |1
        is obsolete|                            |

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2676
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2676&action=edit
revised revised streamlocal -W patch

Same again with a couple of style nits fixed too.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

Todd C. Miller <Todd.Miller at courtesan.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Todd.Miller at courtesan.com

--- Comment #5 from Todd C. Miller <Todd.Miller at courtesan.com> ---
I have an equivalent diff in my own tree that I've tested.  I think
this should go in.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Todd, do you mean the attached diff or the one in your tree? (or that
they are basically the same?)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.