openssh bugs - Dec 2014 - [Bug 2325] New: excessive and unquietable stderr chatter

https://bugzilla.mindrot.org/show_bug.cgi?id=2325

            Bug ID: 2325
           Summary: excessive and unquietable stderr chatter
           Product: Portable OpenSSH
           Version: -current
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh-keygen
          Assignee: unassigned-bugs at mindrot.org
          Reporter: schmiddy at gmail.com

I maintain some code (using cronic, see http://habilis.net/cronic/ )
which is sensitive to any noise generated on stderr, treating it as a
possible error. One culprit causing false alarms is ssh-keygen, which
generates these two messages from around line 1245 of ssh-keygen.c:

fprintf(stderr, "%s updated.\n", identity_file);
fprintf(stderr, "Original contents retained as %s\n", old);

I believe such use of stderr is inconsistent not only with generally
accepted use of stderr elsewhere, but with the rest of the OpenSSH
codebase. Other non-error messages in that file (e.g. "%s: generating
new host keys: ") seem fine with being sent to stdout, and similar
diagnostic messages in that file also respect the "quiet" flag, which
I
would find helpful.

I noticed some other inconsistencies in ssh-keygen.c as well. For
example, this bit (line 888) surely should go to stderr instead of
stdout:

if (invalid) {
        printf("%s is not a public key file.\n", identity_file);
        exit(1);
}

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2325

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at zip.com.au
   Attachment #2593|                            |ok?(dtucker at zip.com.au)
              Flags|                            |

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 2593
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2593&action=edit
convert ssh-keygen to logit/error/fatal

This converts the stderr message you mentioned to stdout, and switches
most stderr messages over to logit/error/fatal

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2325

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2360

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2325

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2593|ok?(dtucker at zip.com.au)     |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2325

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
patch applied - this will be in openssh-6.9

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2325

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.