openssh bugs - Jun 2014 - [Bug 2247] New: [visual host key] fix upper border display

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

            Bug ID: 2247
           Summary: [visual host key] fix upper border display
           Product: Portable OpenSSH
           Version: 6.6p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: mail at eworm.de

Created attachment 2442
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2442&action=edit
rework printing for visual host key upper border

I've sent this patch to mailing list twice, without getting any
feedback.

Key types are getting longer and the current implementation of visual
host key breaks with ED25519, resulting in (note the missing bracket):

+--[ED25519  256--+

This reworks the calculation of visual host key upper border. Please be
aware that this slightly modifies the output for other key types as
well:

+--[ DSA 1024]----+
+---[DSA 1024]----+

+--[ RSA 2048]----+
+---[RSA 2048]----+

+--[ECDSA  256]---+
+---[ECDSA 256]---+

+--[ED25519  256--+
+--[ED25519 256]--+

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

Christian Hesse <mail at eworm.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2442|0                           |1
        is obsolete|                            |

--- Comment #1 from Christian Hesse <mail at eworm.de> ---
Created attachment 2443
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2443&action=edit
rework printing for visual host key upper border

updated patch to avoid useless sprinf, use simple loop instead.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2226
                 CC|                            |djm at mindrot.org

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Put this on the list for openssh-6.7

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

Christian Hesse <mail at eworm.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2443|0                           |1
        is obsolete|                            |

--- Comment #3 from Christian Hesse <mail at eworm.de> ---
Created attachment 2444
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2444&action=edit
rework printing for visual host key upper border

Update to latest git master.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2444|0                           |1
        is obsolete|                            |
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Created attachment 2445
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2445&action=edit
committed patch

That patch doesn't quite fit ED25519-CERT. This one drops the length
when it can't fit.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
patch committed. This will be in openssh-6.7

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sf at 9by6.org

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
*** Bug 2215 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2247

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
Close all bugs left open from 6.6 and 6.7 releases.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.