openssh bugs - May 2014 - [Bug 2240] New: Secure PIN entry for smartcards through the keypad on the reader (patch)

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

            Bug ID: 2240
           Summary: Secure PIN entry for smartcards through the keypad on
                    the reader (patch)
           Product: Portable OpenSSH
           Version: -current
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: dirkx at webweaving.org

Created attachment 2435
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2435&action=edit
patch for secure PIN entry

Folks,

Find below a minor patch to allow the use of smartcards in readers that
have their own
PIN entry keypads (Secure PIN entry) such as the SPR332 and most
german/medical
chipcard devices.

Tested on Solaris, FreeBSD and MacOSX against various cards and
drivers.

I?ve left the pkcs11_interactive check in place. Arguably - with some
Secure PIN readers
it may be better to move this just in front of the keyboard entry ONLY;
as there are some
secure PIN keypads that use means which are somewhat suitable to
unattended 
operation. But I thought it better to let this wait until an actual use
case warrants this
and/or the need for a special flag/argument to control such.

Thanks,

Dw.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

Dirk-Willem van Gulik <dirkx at webweaving.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2435|0                           |1
        is obsolete|                            |

--- Comment #1 from Dirk-Willem van Gulik <dirkx at webweaving.org> ---
Created attachment 2569
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2569&action=edit
Updated patch for same.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

--- Comment #2 from Dirk-Willem van Gulik <dirkx at webweaving.org> ---
Created attachment 2570
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2570&action=edit
Simplified/merged patch

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

calderon.thomas at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |calderon.thomas at gmail.com

--- Comment #3 from calderon.thomas at gmail.com ---
Hi,

I can confirm that this works with Gemalto and Xiring USB readers with
PinPad.

It would be greatly appreciated if this is merged for the next release.

Cheers,

Thomas.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominik at heidler.eu

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
*** Bug 2185 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2360
                 CC|                            |djm at mindrot.org

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
This has been committed and will be in openssh-6.9. The final patch is:

https://anongit.mindrot.org/openssh.git/patch/?id=a71ba58adf34e599f30cdda6e9b93ae6e3937eea

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2240

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.