openssh bugs - Nov 2013 - [Bug 2168] New: Fails to build after arc4random API change in OpenBSD

https://bugzilla.mindrot.org/show_bug.cgi?id=2168

            Bug ID: 2168
           Summary: Fails to build after arc4random API change in OpenBSD
           Product: Portable OpenSSH
           Version: -current
          Hardware: All
                OS: OpenBSD
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jca at wxcvbn.org

Created attachment 2372
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2372&action=edit
Detect arc4random_stir() availability

Since http://marc.info/?l=openbsd-cvs&m=138238762705209&w=2
OpenSSH-portable fails to build on OpenBSD-current (post 5.4). This is
a problem for the OpenBSD ports tree which includes copies of the
openssh-portable source code.

Since other OSes have not implemented yet the improvements made since
10 years to the arc4random API, calling the arc4random_addrandom() or
arc4random_stir() functions is still necessary on those platforms.
Maybe one day we'll finally get rid of those functions.

The patch attached fixes build on OpenBSD-current and any other
platform willing to remove these functions.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2168

Jeremie Courreges-Anglas <jca at wxcvbn.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jca at wxcvbn.org

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2168

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |2130
         Resolution|---                         |FIXED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
I noticed that too on my test system.  Fixed in a similar way, it will
be in 6.5p1.

Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2168

--- Comment #2 from Jeremie Courreges-Anglas <jca at wxcvbn.org> ---
(In reply to Darren Tucker from comment #1)
> I noticed that too on my test system.  Fixed in a similar way, it
> will be in 6.5p1.
> 
> Thanks.
Great.  I should have added that (void(0)) was inspired by the
definition for assert() when NDEBUG is defined, as per the C standards.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2168

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.