openssh bugs - Aug 2013 - [Bug 2137] New: progress meter shows wrong speed during resume

https://bugzilla.mindrot.org/show_bug.cgi?id=2137

            Bug ID: 2137
           Summary: progress meter shows wrong speed during resume
           Product: Portable OpenSSH
           Version: -current
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: sftp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: loganaden at gmail.com

Created attachment 2324
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2324&action=edit
progressmeter diff

Iain Morgan reported that the progress meter would display erroneous
speeds when interrupting and resuming downloads.

I'm attaching a WIP fix.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2137

Iain Morgan <imorgan at nas.nasa.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imorgan at nas.nasa.gov

--- Comment #1 from Iain Morgan <imorgan at nas.nasa.gov> ---
Created attachment 2333
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2333&action=edit
Don't assume that the starting poistion is zero

This looks like it fixes the issue. Save the initial offset when
starting the progress meter and use it when cur_pos is zero. Also, use
it when reporting the statistics for the completed transfer. This also
fixes the negative speed issue when the transfer is interrupted by a
signal.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2137

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |2130

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2137

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
   Attachment #2333|                            |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2137

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
patch applied; thanks

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2137

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.