openssh bugs - Jul 2013 - [Bug 2134] New: invalid prototype for get_last_login_time()

https://bugzilla.mindrot.org/show_bug.cgi?id=2134

            Bug ID: 2134
           Summary: invalid prototype for get_last_login_time()
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: Other
                OS: FreeBSD
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: arthurmesh at gmail.com

Created attachment 2321
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2321&action=edit
proposed fix

simple fix -- found when building OpenSSH with stricter warning sets.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2134

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
   Attachment #2321|                            |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2134

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
             Blocks|                            |2076

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
What options did you use to catch this? Neither gcc nor clang/llvm-3.3
noticed this for me.

In any case, applied - nice catch.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2134

--- Comment #2 from Arthur Mesh <arthurmesh at gmail.com> ---
It was caught using GCC 4.2.1 (with some unknown to me patches), using
the
following set of -Ws:
-Wno-pointer-sign
-Wno-error=address
-W
-Wall
-Wcast-align
-Wchar-subscripts
-Wcomment
-Werror
-Wextra
-Wformat
-Wimplicit
-Winline
-Wmissing-declarations
-Wmissing-prototypes
-Wparentheses
-Wpointer-arith
-Wreturn-type
-Wshadow
-Wstrict-aliasing
-Wstrict-prototypes
-Wswitch
-Wtrigraphs
-Wuninitialized
-Wno-unused-parameter
-Wno-unused

I am not sure which, if any of these, are causing the warning.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2134

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.