openssh bugs - Jun 2013 - [Bug 2113] New: S_IWRITE is considered obsolete and should be replaced with S_IWUSR.

https://bugzilla.mindrot.org/show_bug.cgi?id=2113

            Bug ID: 2113
           Summary: S_IWRITE is considered obsolete and should be replaced
                    with S_IWUSR.
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: nathan.osman at gmail.com

Created attachment 2287
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2287&action=edit
Replaces instances of S_IWRITE with S_IWUSR.

The constant S_IWRITE is used in a couple of places in the OpenSSH
source code. According to the page below, this constant is obsolete:

 
http://www.gnu.org/savannah-checkouts/gnu/libc/manual/html_node/Permission-Bits.html

This causes the following errors when cross-compiling for the Android
platform:

  scp.c:1071:11: error: 'S_IWRITE' undeclared (first use in this
function)
  sftp-client.c:1054:13: error: 'S_IWRITE' undeclared (first use in
this function)

The equivalent constant that should be used in its place is 'S_IWUSR'.
I have attached a patch that corrects these instances.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2113

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |2076

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
Seems reasonable, it's also consistent with SuSv2:
http://pubs.opengroup.org/onlinepubs/007908799/xsh/sysstat.h.html

put on the list for 6.3

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2113

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
Applied, thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2113

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.