openssh bugs - May 2013 - [Bug 2103] New: remote command as an option in ssh_config

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

            Bug ID: 2103
           Summary: remote command as an option in ssh_config
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: daniel.black at ovee.com.au

feature request for remote command to be allowed to be specified in the
ssh_config.

What I'd like this for is to set up entries like:

host client-tx-web02-console
        user clientname
        hostname lish-dallas.linode.com
        RequestTTY force
        RemoteCommand  tx-web02

This would be for Linode's lish console but other uses are convenient:
( https://blog.linode.com/2013/04/30/lish-ssh-gateway/ )

This perhaps would solve part the requirement in #1368 too.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

Daniel Black <daniel.subs at internode.on.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.subs at internode.on.ne
                   |                            |t

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #1 from Daniel Black <daniel.subs at internode.on.net> ---
Created attachment 2348
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2348&action=edit
simple patch

First simple patch of the implementation.

I probably should implement a bunch of percent_expand expressions on
it. Thoughts?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #2 from Daniel Black <daniel.subs at internode.on.net> ---
Created attachment 2349
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2349&action=edit
RemoteCommand / PermitRemoteCommand + tests and doco

Since PermitLocalCommand is required for LocalCommand I added
PermitRemoteCommand in the same way.

RemoteCommand can take a number of expansions.

The command as an argument to ssh will always disable RemoteCommand.

Patch includes test cases and manual changes.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

Daniel Black <daniel.subs at internode.on.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2348|0                           |1
        is obsolete|                            |
   Attachment #2349|0                           |1
        is obsolete|                            |

--- Comment #3 from Daniel Black <daniel.subs at internode.on.net> ---
Created attachment 2350
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2350&action=edit
RemoteCommand / PermitRemoteCommand + tests and doco (with tabs)

Fixes whitespace

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

main.haarp at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |main.haarp at gmail.com

--- Comment #4 from main.haarp at gmail.com ---
*** Bug 2558 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #5 from main.haarp at gmail.com ---
Created attachment 2839
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2839&action=edit
RemoteCommand for openssh-7.2_p2

Thank you for this patch, Daniel! I've been looking for this for quite
a while. Juggling aliases is very annoying. (see bug 2558)

I've ported the over to v7.2_p2. I left out PermitRemoteCommand
however, as it is pretty pointless when anyone can just specify it on
the command line anyway.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

daniel.black at au.ibm.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.black at au.ibm.com

--- Comment #6 from daniel.black at au.ibm.com ---
Thanks, good call on PermitRemoteCommand

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

Derek Schrock <dereks at lifeofadishwasher.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dereks at lifeofadishwasher.co
                   |                            |m

--- Comment #7 from Derek Schrock <dereks at lifeofadishwasher.com> ---
Would it be possible to have this patch updated to handle ssh's -N? 
'RemoteCommand none' perhaps?

RemoteCommand none   # Do not execute a remote command.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

Daniel Black <daniel.subs at internode.on.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Daniel Black <daniel.subs at internode.on.net> ---
new in OpenSSH-7.6 
http://www.openssh.com/txt/release-7.6

thank you Alexander Bluhm

sorry to see you missing credits in Release notes (along with Mike
Frysinger and Ingo Schwarze)

patches:

https://github.com/openssh/openssh-portable/commit/1112b534a6a7a07190e497e6bf86b0d5c5fb02dc

https://github.com/bluhm/ssh/commit/e49bd120b209e48186243c5375b46b95363ac101#diff-b7f1e8dab0f3981a0a9c8c50af26d12b

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #9 from main.haarp at gmail.com ---
It got merged, but in a modified version.

Now specifying a command line to ssh while RemoteCommand is active
results in:

"Cannot execute command-line and remote command."

instead of having the commandline override the RemoteCommand.

which makes it very inconvenient, if not outright confusing and
annoying to have it set in your ssh config :(

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #10 from daniel.black at au.ibm.com ---
Quite right: 

https://github.com/openssh/openssh-portable/commit/1112b534a6a7a07190e497e6bf86b0d5c5fb02dc#diff-5bfa45f3fb322e569a8101399c9c551cR1130

the following would of been sufficient:

if (buffer_len(&command) != 0) options.remote_command = NULL;

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #11 from main.haarp at gmail.com ---
Created attachment 3067
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3067&action=edit
allow overriding RemoteCommand, allocate TTY

Additionally, no TTY is allocated for RemoteCommands by default.

Took me a while to figure out why my interactive shells were quite
broken :)

Both of these can be rectified with the attached patch, if anyone's
interested.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #12 from Daniel Black <daniel at linux.vnet.ibm.com> ---
Probably best to add that patch to new opened bug. While I could reopen
this the new patch is closer to bug fix as opposed to this feature
request so might get more attention.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

--- Comment #13 from main.haarp at gmail.com ---
Good point, Daniel. I have done so. See bug 2801.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2103

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.