openssh bugs - Sep 2012 - [Bug 2043] New: memleak in import_environments

https://bugzilla.mindrot.org/show_bug.cgi?id=2043

          Priority: P5
            Bug ID: 2043
          Assignee: unassigned-bugs at mindrot.org
           Summary: memleak in import_environments
          Severity: trivial
    Classification: Unclassified
                OS: All
          Reporter: arthurmesh at gmail.com
          Hardware: All
            Status: NEW
           Version: 6.1p1
         Component: sshd
           Product: Portable OpenSSH

Created attachment 2189
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2189&action=edit
fix

Potential fix attached.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2043

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
   Attachment #2189|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #2189|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2043

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Unfortunately, it's not possible to safely free this here as
pam_putenv() is underspecified: it is not guaranteed to either copy the
environment it is setting or take over ownership of it. The safest
behaviour here is just to accept the one-time leak :(

I have added a comment to explain this in auth-pam.c

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2043

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
close bugs that were resolved in OpenSSH 8.5 release cycle

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.