openssh bugs - Oct 2010 - [Bug 1830] New: Patch to get py-bcrypt to build for Python 2.6 on Windows

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

           Summary: Patch to get py-bcrypt to build for Python 2.6 on
                    Windows
           Product: py-bcrypt
           Version: -current
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Default
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: rasjidw at gmail.com


Patch to get py-bcrypt module to build on Windows (using VS2008, Python
2.6).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

--- Comment #1 from Rasjid <rasjidw at gmail.com> 2010-10-19 12:08:46 EST
---
Created attachment 1938
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1938
Patch for building on Win32

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #2 from Damien Miller <djm at mindrot.org> 2010-11-01 10:50:51
EST ---
What error does this fix? I'd prefer not to make extra copies of the
password as each increases the chance that it will remain in memory.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

--- Comment #3 from Rasjid <rasjidw at gmail.com> 2010-11-01 14:27:49 EST
---
(In reply to comment #2)
> What error does this fix? I'd prefer not to make extra copies of the
> password as each increases the chance that it will remain in memory.
See attached build log.  This was on Windows XP SP3, using MS Visual
C++ 2008 Express Edition as the compiler.

There may well be a better way of fixing this.  Although I've been
programming in Python for quite a while, I'm extremely new to C.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

--- Comment #4 from Rasjid <rasjidw at gmail.com> 2010-11-01 14:29:34 EST
---
Created attachment 1941
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1941
Build log (with errors) of current version (without patches).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

wahaa <mutuka+mindrot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mutuka+mindrot at gmail.com

--- Comment #5 from wahaa <mutuka+mindrot at gmail.com> 2011-03-07
01:18:25 EST ---
(In reply to comment #2)
> What error does this fix? I'd prefer not to make extra copies of the
> password as each increases the chance that it will remain in memory.
The patch only moves the declarations of the variables to the beginning
of the block, so no extra copies. 

With it applied, py-bcrypt builds (and tests) successfully with both
Python 2.6.6 and Python 2.7.1 (using MSVC 2008).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

tweir at geekwerks.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tweir at geekwerks.ca

--- Comment #6 from tweir at geekwerks.ca 2011-03-28 10:36:10 EST ---
It looks like the MSVC compiler is being extra strict. I.e. enforcing C
the standard (declare all variables at top of function) as opposed to
the less strict c++ style rule (declare anywhere, prior to first use).

I'd strongly recommend accepting this patch. The patch only moves the
declaration of the variables, it does not affect the duplication
operation in anyway.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Damien Miller <djm at mindrot.org> 2011-03-28 12:04:33
EST ---
Patch has been committed:
http://code.google.com/p/py-bcrypt/source/detail?r=1cbdb1427b

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1830

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Damien Miller <djm at mindrot.org> 2011-09-06 15:32:51
EST ---
close resolved bugs now that openssh-5.9 has been released

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.