openssh bugs - Mar 2010 - [Bug 1735] New: build failure if ENABLE_PKCS11 is not defined

https://bugzilla.mindrot.org/show_bug.cgi?id=1735

           Summary: build failure if ENABLE_PKCS11 is not defined
           Product: Portable OpenSSH
           Version: 5.4p1
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: felix-mindrot at fefe.de


When ENABLE_PKCS11 is not defined (probably my fault, will investigate
separately), openssh will fail to build because the #ifdef in
ssh-pkcs11-helper.c skips the part that #includes log.h, which defines
SYSLOG_LEVEL_ERROR and SYSLOG_FACILITY_AUTH.  Those (and the prototype
for log_init) are needed on line 369.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1735

--- Comment #1 from Felix von Leitner <felix-mindrot at fefe.de>
2010-03-13 17:04:28 EST ---
I found out why my build did not define ENABLE_PKCS11.  I was building
a statically linked binary with my embedded libc.

There is another, related bug.  ssh-pkcs11-helper fails to build in the
above configuration, because it has an undefined reference to xstrdup. 
That is used by bsd-misc.o but not linked into openbsd-compat.a.
When I add xmalloc.o manually to openbsd-compat.a, the build works.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1735

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Damien Miller <djm at mindrot.org> 2010-03-14 08:43:42
EST ---
Thanks for the report; fixes to both issues (bad #ifdef order and
broken -lssh dep) have been committed and will be in the next release.
For the xstrdup thing, I just appended -lssh to the link line - we
already do this for ssh-keyscan.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1735

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> 2010-04-16 15:51:13
EST ---
Mass move of bugs RESOLVED->CLOSED following the release of
openssh-5.5p1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.