openssh bugs - Mar 2010 - [Bug 1732] New: Proper utmpx support for FreeBSD HEAD

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

           Summary: Proper utmpx support for FreeBSD HEAD
           Product: Portable OpenSSH
           Version: 5.4p1
          Platform: Other
        OS/Version: FreeBSD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sshd
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: ed at 80386.nl


Created an attachment (id=1805)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1805)
OpenSSH + FreeBSD's utmpx

In order to make utmpx logging and lastlog information work on FreeBSD
HEAD, the attached patch is required. FreeBSD's <utmpx.h> doesn't
declare all sorts of path name definitions. Its lastlog interface is
also part of the utmpx API itself.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

Ed Schouten <ed at 80386.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1805|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #1805|0                           |1
           is patch|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

--- Comment #1 from Damien Miller <djm at mindrot.org> 2010-03-26 10:59:57
EST ---
(From update of attachment 1805)
>-
>-dnl utmpx detection - I don't know any system so perverse as to require
>-dnl  utmpx, but not define UTMPX_FILE (ditto wtmpx.) No doubt it's out
>-dnl  there, though.
>-AC_MSG_CHECKING([if your system defines UTMPX_FILE])
>-AC_TRY_COMPILE([
>-#include <sys/types.h>
>-#include <utmp.h>
>-#ifdef HAVE_UTMPX_H
>-#include <utmpx.h>
>-#endif
>-#ifdef HAVE_PATHS_H
>-#  include <paths.h>
>-#endif
>-	],
>-	[ char *utmpx = UTMPX_FILE; ],
>-	[ AC_MSG_RESULT(yes) ],
>-	[ AC_MSG_RESULT(no)
>-	  system_utmpx_path=no ]
>-)
>-if test -z "$conf_utmpx_location"; then
>-	if test x"$system_utmpx_path" = x"no" ; then
>-		AC_DEFINE(DISABLE_UTMPX)
>-	fi
>-else
>-	AC_DEFINE_UNQUOTED(CONF_UTMPX_FILE, "$conf_utmpx_location",
>-		[Define if you want to specify the path to your utmpx file])
>-fi
Why are you deleting this section? This might affect platforms other
than FreeBSD.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

--- Comment #2 from Ed Schouten <ed at 80386.nl> 2010-03-26 18:26:15 EST
---
I am quite sure that this won't cause any breakage. As long as the
implementation provides the utmpx structure and the functions required
by POSIX, why shouldn't we use it then?

FreeBSD's <utmpx.h> doesn't provide the *TMPX_FILE definitions
which
are present in other implementations for two reasons:

- It is not standardized by POSIX.
- I never want applications to access the utmpx files manually.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> 2010-04-09
12:20:46 EST ---
(In reply to comment #2)
> I am quite sure that this won't cause any breakage. As long as the
> implementation provides the utmpx structure and the functions required
> by POSIX, why shouldn't we use it then?
but your change also disables the setting of CONF_UTMPX_FILE based on
anything that sets conf_utmpx_location (which seems to include at least
the netbsd pkgsrc package).

That said, nothing in our code actually uses CONF_UTMPX_FILE, so maybe
it doesn't matter (any more?)

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

--- Comment #4 from Ed Schouten <ed at 80386.nl> 2010-04-09 17:32:25 EST
---
(In reply to comment #3)
> That said, nothing in our code actually uses CONF_UTMPX_FILE, so maybe
> it doesn't matter (any more?)
Exactly!

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1743
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> 2010-04-09
18:15:18 EST ---
OK, sold!  Thanks for the patch, it has been applied and will be in
5.5p1.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1732

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> 2010-04-16 15:50:32
EST ---
Mass move of bugs RESOLVED->CLOSED following the release of
openssh-5.5p1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.