openssh bugs - Sep 2009 - [Bug 1648] New: Fix IPV6_V6ONLY for -L with -g

https://bugzilla.mindrot.org/show_bug.cgi?id=1648

           Summary: Fix IPV6_V6ONLY for -L with -g
           Product: Portable OpenSSH
           Version: -current
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: jan.kratochvil at redhat.com


Created an attachment (id=1695)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1695)
Fix following the current openssh style.

$ /usr/bin/ssh -g -L 5000:localhost:22 localhost cat
bind: Address already in use
[... running]
# netstat -apn|grep 5000
tcp  0  0  0.0.0.0:5000  0.0.0.0:*  LISTEN  23526/ssh
$ telnet localhost6 5000
Trying ::1...
telnet: connect to address ::1: Connection refused

patched:

$ ./ssh -g -L 5000:localhost:22 localhost cat
[... running]
# netstat -apn|grep 5000
tcp  0  0  0.0.0.0:5000  0.0.0.0:*  LISTEN  23139/ssh
tcp  0  0  :::5000       :::*       LISTEN  23139/ssh
$ telnet localhost6 5000
Trying ::1...
Connected to localhost6.
Escape character is '^]'.
SSH-2.0-OpenSSH_5.2


Using Fedora 11 kernel with its (+AFAIK upstream) defaults:
# cat /proc/version 
Linux version 2.6.30.5-43.fc11.x86_64
(mockbuild at xenbuilder4.fedora.phx.redhat.com) (gcc version 4.4.1
20090725 (Red Hat 4.4.1-2) (GCC) ) #1 SMP Thu Aug 27 21:39:52 EDT 2009
# cat /proc/sys/net/ipv6/bindv6only
0

In the current case one cannot access IPv6 because the IPv4 socket was
created first.  If IPv6 would be created first it would work.

The copy-pasted code could be probably moved to some unified function. 
This is out of scope of this patch.

Similiar problem+resolution was in Bug 164, Bug 1309 and Bug 1392.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1648

Jan Kratochvil <jan.kratochvil at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1695|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #1695|0                           |1
           is patch|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1648

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1626

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1648

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1695|0                           |1
        is obsolete|                            |
   Attachment #1720|                            |ok?
               Flag|                            |

--- Comment #1 from Damien Miller <djm at mindrot.org> 2009-11-10 14:13:52
EST ---
Created an attachment (id=1720)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1720)
unify setsockopt(...,IPV6_V6ONLY,...) calls

Good idea about unifying the calls to setsockopt. Here is a diff that
does that (includes your change too).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1648

--- Comment #2 from Damien Miller <djm at mindrot.org> 2009-11-18 17:49:05
EST ---
patch applied. this will be in openssh-5.4, thanks for the
report+patch.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1648

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1648

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> 2010-03-26
10:51:11 EST ---
With the release of 5.4p1, this bug is now considered closed.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.