openssh bugs - Aug 2008 - [Bug 1502] New: Incompatible declaration of AuthctxtV2.success

https://bugzilla.mindrot.org/show_bug.cgi?id=1502

           Summary: Incompatible declaration of AuthctxtV2.success
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 5.0p1
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: THanson at CardinalPeak.com


Source file sshconnect2.c contains the definition of structure
AuthctxtV2.  Field "success" in this structure is declared as type
"int".  

In function ssh_userauth2(), authctxt.success is passed to
dispatch_run() as the second argument.  

dispatch_run() is declared in dispatch.c with a second parameter of
type sig_atomic_t.

On some OS's (i.e. VxWorks) "sig_atomic_t" is declared as
"unsigned
char".  Where the system is also big-endian, the size mismatch between
"sig_atomic_t" as "unsigned char" and
"authctxt.success" as "int"
causes the data to be written to / read from different bytes.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1502





--- Comment #1 from Tom Hanson <THanson at CardinalPeak.com>  2008-08-12
02:44:39 ---
Source file sshconnect2.c contains the definition of structure
AuthctxtV2.  Field "success" in this structure is declared as type
"int".  

In function ssh_userauth2(), authctxt.success is passed to
dispatch_run() as the second argument.  

dispatch_run() is declared in dispatch.c with a second parameter of
type sig_atomic_t.

On some OS's (i.e. VxWorks) "sig_atomic_t" is declared as
"unsigned
char".  Where the system is also big-endian, the size mismatch between
"sig_atomic_t" as "unsigned char" and
"authctxt.success" as "int"
causes the data to be written to / read from different bytes. 
Specifically, the result written by dispatch_run() is not seen b

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1502





--- Comment #2 from Tom Hanson <THanson at CardinalPeak.com>  2008-08-12
02:45:05 ---
Source file sshconnect2.c contains the definition of structure
AuthctxtV2.  Field "success" in this structure is declared as type
"int".  

In function ssh_userauth2(), authctxt.success is passed to
dispatch_run() as the second argument.  

dispatch_run() is declared in dispatch.c with a second parameter of
type sig_atomic_t.

On some OS's (i.e. VxWorks) "sig_atomic_t" is declared as
"unsigned
char".  Where the system is also big-endian, the size mismatch between
"sig_atomic_t" as "unsigned char" and
"authctxt.success" as "int"
causes the data to be written to / read from different bytes.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1502

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1708

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1502

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Damien Miller <djm at mindrot.org>  ---
Fixed in CVS. Will be in openssh-5.6 -thanks!

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1502

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> 2011-01-24 12:33:34
EST ---
Move resolved bugs to CLOSED after 5.7 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.