openssh bugs - Jan 2008 - [Bug 1427] New: scp -q behavior different than documented

https://bugzilla.mindrot.org/show_bug.cgi?id=1427

           Summary: scp -q behavior different than documented
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 4.7p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P3
         Component: scp
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: mikel at mikelward.com


Created an attachment (id=1434)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1434)
only disable the progress meter, keep error messages

The man page says -q disables the progress meter, but it also disables
all other output.

$ scp -q badhost:/bin/ls .

$ scp badhost:/bin/ls . 
ssh: badhost: Name or service not known

I would like -q to disable the progress meter as documented (I don't
see
the point of a -q flag if all it does is discards stderr, since I can
already do that with my shell), but you might prefer to update the man
page to reflect the current behavior instead.

Tested with openssh-4.7p1 on Fedora.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1427





--- Comment #1 from Mikel Ward <mikel at mikelward.com>  2008-01-07
11:24:12 ---
Created an attachment (id=1435)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1435)
alternative: update the man page to reflect current behavior

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1427





--- Comment #2 from Mikel Ward <mikel at mikelward.com>  2008-01-07
11:28:13 ---
I tested the first patch briefly.  It fixes my test case and seems to
be the obvious change.

I haven't tested the second patch.  It just changes the man page.

The third option is to take a deeper look at the behavior of -q in all
of OpenSSH.  My ideal would be that -q turns off things like banners
but still prints errors.  That way I could run cron jobs using scp
and/or ssh and only get emailed if something broke.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1427





--- Comment #3 from Mikel Ward <mikel at mikelward.com>  2008-01-07
11:30:38 ---
It seems the behavior was changed in 2003.  It used to do what the man
page said, but it got changed to turn off all stderr output.  The
intent was to disable banners, but it also silences any errors, which I
think is undesirable.

revision 1.121
date: 2003/11/17 10:19:05;  author: djm;  state: Exp;  lines: +2 -1
   - dtucker at cvs.openbsd.org 2003/11/12 10:12:15
     [scp.c]
     When called with -q, pass -q to ssh; suppresses SSH2 banner.  ok
markus@

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1427





--- Comment #4 from Mikel Ward <mikel at mikelward.com>  2008-01-07
17:14:25 ---
Created an attachment (id=1436)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1436)
better: make -q show only critical messages in ssh and scp

This changes -q to suppress all messages below SYSLOG_LEVEL_FATAL.

This gives us:
- no progress bar (as documented)
- no banners (as per Darren Tucker's patch that was already committed)
- messages if the connection fails

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1427


Mikel Ward <mikel at mikelward.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1436 is|0                           |1
           obsolete|                            |




--- Comment #5 from Mikel Ward <mikel at mikelward.com>  2008-01-07
17:26:52 ---
Created an attachment (id=1437)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1437)
better: make -q show only critical messages in ssh and scp

Previous patch plus a minor change to clientloop.c just in case
somebody decides to change SYSLOG_LEVEL_QUIET at a later date.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1427


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
                 CC|                            |djm at mindrot.org
             Blocks|                            |1353




--- Comment #6 from Damien Miller <djm at mindrot.org>  2008-01-20
06:26:04 ---
The scp manual page has been updated to reflect the true behaviour. BTW
I think having -q consistent between ssh and scp is desirable.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1427


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added                       
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED                      




--- Comment #7 from Damien Miller <djm at mindrot.org>  2008-03-31
15:23:33 ---
Fix shipped in 4.9/4.9p1 release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.