openssh bugs - Aug 2007 - [Bug 1354] New: slight problems with sftp client

http://bugzilla.mindrot.org/show_bug.cgi?id=1354

           Summary: slight problems with sftp client
           Product: Portable OpenSSH
           Version: 4.6p1
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sftp
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: t8m at centrum.cz


We've found 2 slight problems with sftp client.

1. when uploading files to an almost full disk on remote system the
sftp client aborts prematurely with ID mismatch error. This happens
because of not draining acks from the remote side properly.

2. if the above problem is fixed this problem appears - when uploading
multiple files with wildcard match in the same situation it will not
abort the command on first failed transfer but it tries to transfer the
remaining matching files.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1354





--- Comment #1 from Tomas Mraz <t8m at centrum.cz>  2007-08-14 19:45:31
---
Created an attachment (id=1340)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1340)
Patch for draining the acks properly

This is the patch for the first problem.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1354





--- Comment #2 from Tomas Mraz <t8m at centrum.cz>  2007-08-14 19:55:32
---
Created an attachment (id=1341)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1341)
Patch for the second problem

This patch fixes the second problem. On the other hand it is debatable
whether the second problem is a real bug or rather a feature.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1354


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |djm at mindrot.org
             Blocks|                            |1353




--- Comment #3 from Damien Miller <djm at mindrot.org>  2007-11-03
15:51:48 ---
I agree about the 2nd not being a bug for interactive use, but perhaps
we should allow early termination of the upload when we are in strict
error more (e.g. batchmode).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1354


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Damien Miller <djm at mindrot.org>  2008-01-22
06:24:56 ---
1st patch applied - thanks.

I'm not going to change the behaviour of sftp when one file in the
middle of a up/download batch fails. Continuing the transfer is the
most friendly thing to do for interactive use, and I don't want the
commands to have different semantics when batchmode is active.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1354


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added                       
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED                      




--- Comment #5 from Damien Miller <djm at mindrot.org>  2008-03-31
15:21:04 ---
Fix shipped in 4.9/4.9p1 release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.