openssh bugs - Sep 2006 - [Bug 1234] configure adds opensc libs to LDFLAGS when it should use LIBS

http://bugzilla.mindrot.org/show_bug.cgi?id=1234

           Summary: configure adds opensc libs to LDFLAGS when it should use
                    LIBS
           Product: Portable OpenSSH
           Version: -current
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: vapier at gentoo.org


configure.ac does this:
                        LIBOPENSC_CFLAGS=`$OPENSC_CONFIG --cflags`
                        LIBOPENSC_LIBS=`$OPENSC_CONFIG --libs`
                        CPPFLAGS="$CPPFLAGS $LIBOPENSC_CFLAGS"
                        LDFLAGS="$LDFLAGS $LIBOPENSC_LIBS"

since we're grabbing libs, we actually want to be sticking that into
LIBS

otherwise, when the binaries get linked, they're of the form:
$(CC) <objects> -o ssh $LDFLAGS <sshlibs> $LIBS

so -lopensc goes into LDFLAGS instead of LIBS and if we use something
like -static or --as-needed in LDFLAGS, the build aborts because the
<sshlibs> use symbols from -lopensc but -lopensc is discarded before
sshlibs get processed




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1234





------- Comment #1 from vapier at gentoo.org  2006-09-23 14:54 -------
Created an attachment (id=1186)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1186&action=view)
openssh-opensc-libs.patch

patch against current portable openssh cvs tree




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1234


dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from dtucker at zip.com.au  2006-09-23 16:26 -------
Looks sane and test OK here.  Applied, thanks.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1234


dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




------- Comment #3 from dtucker at zip.com.au  2006-10-07 11:45 -------
Change all RESOLVED bug to CLOSED with the exception of the ones fixed
post-4.4.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.