openssh bugs - Feb 2006 - [Bug 1162] Inappropriate sequence of syslog messages

http://bugzilla.mindrot.org/show_bug.cgi?id=1162

           Summary: Inappropriate sequence of syslog messages
           Product: Portable OpenSSH
           Version: 4.2p1
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sshd
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: senthilkumar_sen at hotpop.com


I came across Inappropriate sequence of syslog messages saying server is
listening on desired port when the listen call fails.

Feb 24 12:41:38 ssh-165 sshd[2616]: Server listening on 0.0.0.0 port 1111.
Feb 24 12:41:38 ssh-165 sshd[2616]: fatal: listen: Socket operation on
non-socket




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1162





------- Comment #1 from senthilkumar_sen at hotpop.com  2006-02-24 16:14 -------
Created an attachment (id=1080)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1080&action=view)
Patch to fix the Inappropriate sequence of log messages

This behaviour also happens with bind() call and the attached patch fixes the
problem. 




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1162





------- Comment #2 from dtucker at zip.com.au  2006-03-08 00:04 -------
(From update of attachment 1080)
>-                       debug("Bind to port %s on %s.", strport,
ntop);
These things are only debugs and are intended to describe what it's about to
try
(and thus the source of any immediately subsequent errors).
>-                       logit("Server listening on %s port %s.",
ntop, strport);
>                        if (listen(listen_sock, SSH_LISTEN_BACKLOG) <
0)
>                                fatal("listen: %.100s",
strerror(errno));
>+                       else
>+                               logit("Server listening on %s port
%s.", ntop, strport);
The problem with doing that is that if it fails you now don't know which of
the
ports that the listen failed on (remember, there can be more than one).




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1162


djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1080 is|0                           |1
           obsolete|                            |




------- Comment #3 from djm at mindrot.org  2006-03-12 15:20 -------
Created an attachment (id=1096)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1096&action=view)
Reorder log statement

This is probably better, and simpler




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1162


dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1096|                            |ok+
               Flag|                            |




------- Comment #4 from dtucker at zip.com.au  2006-03-13 19:13 -------
(From update of attachment 1096)
ok by me




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1162


djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |1155
              nThis|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #5 from djm at mindrot.org  2006-03-13 19:18 -------
patch applied, will be in 4.4




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.