openssh bugs - Feb 2004 - [Bug 802] sshd of openssh-3.8p1 doesn't link on Tru64.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

           Summary: sshd of openssh-3.8p1 doesn't link on Tru64.
           Product: Portable OpenSSH
           Version: 3.8p1
          Platform: Alpha
        OS/Version: OSF/1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: Georg.Wittig at ZV.Fraunhofer.de


sshd of openssh-3.8p1 doesn't link. Linking worked on all prior versions of
openssh.
OS: Tru64 (OSF/1) 4.0f
Symptom:

gcc -o sshd sshd.o auth-rhosts.o auth-passwd.o auth-rsa.o auth-rh-rsa.o sshpty.o
sshlogin.o servconf.o serverloop.o uidswap.o auth.o auth1.o auth2.o
auth-options.o session.o auth-chall.o auth2-chall.o groupaccess.o auth-skey.o
auth-bsdauth.o auth2-hostbased.o auth2-kbdint.o auth2-none.o auth2-passwd.o
auth2-pubkey.o monitor_mm.o monitor.o monitor_wrap.o monitor_fdpass.o kexdhs.o
kexgexs.o auth-krb5.o auth2-gss.o gss-serv.o gss-serv-krb5.o loginrec.o
auth-pam.o auth-shadow.o auth-sia.o md5crypt.o -L. -Lopenbsd-compat/
-L/usr/local/ssl/lib -L/usr/local/staff/tcp_wrappers/src -s
-Wl,-rpath,/usr/local/ssl/lib:/vol/gnu/lib -lssh -lopenbsd-compat -lwrap 
-lcrypto -lrt -lz  -lsecurity -ldb -lm -laud
ld:
Unresolved:
xcrypt
shadow_pw
collect2: ld returned 1 exit status

At least shadow_pw doesn't exist in any library that comes with Tru64
(didn't
check for xcrypt). The symptoms don't change when I add or omit the
--with-osfsia configure option.

Looking at auth-passwd.c of 3.8p1 and 3.7.1p2 showed that adding the option
--with-cflags=-DCUSTOM_SYS_AUTH_PASSWD to configure could help on 3.8p1. And
indeed, it does help. sshd now links and runs correctly. But I don't know if
this is the correct solution or just a work-around.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802





------- Additional Comments From mouring at eviladmin.org  2004-02-27 06:15
-------
both of these fuctions are in openbsd-compat/xcrypt.c

It is wrapped around a !HAVE_OSF_SIA

Some research would have to be done to find if this is still required anymore.

If you remove the "#if !defined(HAVE_OSF_SIA)" near the top of the
xcrypt.c
file and the "endif /* !defined(HAVE_OSF_SIA) */"

Does the problem also go away?  And do you still have a working sshd?

- Ben




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802





------- Additional Comments From Georg.Wittig at ZV.Fraunhofer.de  2004-02-27
06:45 -------
I commented out the "#if !defined(HAVE_OSF_SIA)" in
openbsd-compat/xcrypt.c.
Then I reran configure (without the --with-cflags option) and make.
sshd links fine and it works o.k.

Now we have 2 possible solutions (or work-arounds?).




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802





------- Additional Comments From mouring at eviladmin.org  2004-02-27 14:20
-------
Created an attachment (id=554)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=554&action=view)
More correct SIA fix.

After Looking at the coding cleanup I realized that we were a too harsh.  If
SIA is detected the rest of the code after it is garbage that is never called.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802





------- Additional Comments From dtucker at zip.com.au  2004-02-27 14:37 -------
Created an attachment (id=555)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=555&action=view)
Move osf auth to auth-sia.c

I'd rather see the OSF SIA specific bits banished entirely to auth-sia.c,
like
so.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

mouring at eviladmin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #554 is|0                           |1
           obsolete|                            |





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802





------- Additional Comments From mouring at eviladmin.org  2004-02-27 14:47
-------
Darren's is better.  Assuming we never trigger KRB5/SHADOW stuff with SIA
enabled.  Maybe as a
separate patch we may want to consider ensuring they are never set together.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802





------- Additional Comments From dtucker at zip.com.au  2004-02-27 15:28 -------
Created an attachment (id=556)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=556&action=view)
Move sys_auth_password for OSF SIA to auth-sia.c

Attempt 2.  Undef's USE_SHADOW if OSF SIA is enabled.  I left KRB5 alone
since
it must me enabled manually at configure time.

ALso, I think removing the "#if !defined(HAVE_OSF_SIA)" from xcrypt.c
is safe,
because it only ends up in libopenbsd-compat.a, and if it's not used by sshd
it
won't get linked in anyway.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Attachment #556|                            |ok
             Status|                            |



------- Additional Comments From djm at mindrot.org  2004-02-27 15:46 -------
(From update of attachment 556)
Looks OK, for both trunk and V_3_8 branch




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #555 is|0                           |1
           obsolete|                            |





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #556 is|0                           |1
           obsolete|                            |



------- Additional Comments From dtucker at zip.com.au  2004-03-02 06:32 -------
Created an attachment (id=558)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=558&action=view)
Move sys_auth_passwd for OSF SIA to auth-sia.c

Correction: sys_auth_password -> sys_auth_passwd



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802





------- Additional Comments From Georg.Wittig at ZV.Fraunhofer.de  2004-03-03
21:30 -------
With the attachment 558 the sshd of openssh-3.8p1 now compiles, links, and works
fine for me on Tru64.

Thanks to all who helped.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2004-03-04 23:00 -------
Patch applied, thanks for the report.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

mouring at eviladmin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcaskill.scott at epa.gov



------- Additional Comments From mouring at eviladmin.org  2004-03-05 08:54
-------
*** Bug 807 has been marked as a duplicate of this bug. ***



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=802

mouring at eviladmin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Nikola.Milutinovic at ev.co.yu



------- Additional Comments From mouring at eviladmin.org  2004-03-19 08:12
-------
*** Bug 814 has been marked as a duplicate of this bug. ***



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.