openssh bugs - Sep 2003 - [Bug 709] refresh_progress_meter() appends null bytes

http://bugzilla.mindrot.org/show_bug.cgi?id=709

           Summary: refresh_progress_meter() appends null bytes
           Product: Portable OpenSSH
           Version: -current
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P4
         Component: scp
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: Robert.Dahlem at siemens.com


Since 3.7.1p1 refresh_progress_meter() appends a null byte every time the
progress meter is updated. 

This is quite disturbing on terminals which skip to the next line when a null
byte is written to the last column.

It is an off-by-one-bug: win_size is the string length including terminating
null byte, so atomicio() must not write more than win_size-1 bytes to stdout.
Perhaps strlen(buf) would be better than win_size-1 ...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=709





------- Additional Comments From Robert.Dahlem at siemens.com  2003-09-24 02:42
-------
Created an attachment (id=461)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=461&action=view)
proposed patch




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=709

markus at openbsd.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From markus at openbsd.org  2003-09-24 06:40 -------
thanks, applied.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.