openssh bugs - Sep 2003 - [Bug 670] SunOS 4.1.2 libs do not contain strtoul, used in moduli.c

http://bugzilla.mindrot.org/show_bug.cgi?id=670

           Summary: SunOS 4.1.2 libs do not contain strtoul, used in
                    moduli.c
           Product: Portable OpenSSH
           Version: 3.7p1
          Platform: Sparc
        OS/Version: SunOS
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: nforrester at whoi.edu


Make fails on SunOS 4.1.2 system when linking ssh-keygen for lack of
"strtoul"
in library.  Using gcc with Sun provided libraries (libc?) rather than gnu
libraries.  strtoul is used in moduli.c, which is a new file in openssh 3.7p1
vs. 3.5p1, which previously compiled fine.

I am unsure whether the right approach is a change in the configure process to
detect this and provide an alternate strtoul, or whether the use of strtoul
could be avoided through use of strtol in this case.  

Of course the other solution is to declare a lack of support for old OSs, but
those legacy applications just live on...

I have not the knowledge required to propose a fix, but I am willing to test.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670





------- Additional Comments From nforrester at whoi.edu  2003-09-18 07:52
-------
Oops forgot to say that I configured with the following command:

./configure --prefix=/usr/local --sysconfdir=/etc/ssh --with-tcp-wrappers
--without-shadow --with-prngd-socket=/var/run/egd-pool

then:

make



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670





------- Additional Comments From dtucker at zip.com.au  2003-09-18 13:43 -------
I don't think strtol is an acceptable substitute.

It should be relatively easy to use OpenBSD's strtoul in openbsd-compat:
http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/stdlib/strtoul.c



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670





------- Additional Comments From dtucker at zip.com.au  2003-09-18 13:56 -------
Created an attachment (id=420)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=420&action=view)
Add strtoul in openbsd-compat/

Please try the attached patch.	Note that you will need to run
"autoconf" to
rebuild configure.

If you don't have autoconf, you can use this file:
http://www.zip.com.au/~dtucker/openssh/configure-strtoul.gz , just replace the
configure from 3.7.1p1 with it.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670





------- Additional Comments From nforrester at whoi.edu  2003-09-19 05:59
-------
The patch seems to fix the problem nicely.  Thanks.  As I do not have autoconf
on that machine, I did use your alternate configure.

patch <patchfile
configure-strtoul [options]
make
make install

all worked fine, and ssh and sshd seem to run fine.

Thanks again.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch



------- Additional Comments From dtucker at zip.com.au  2003-10-07 17:10 -------
Anyone object to patch id 420 going into -current?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670





------- Additional Comments From djm at mindrot.org  2003-10-07 17:26 -------
ok by me



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2003-10-07 17:50 -------
Applied to -current, thanks.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=670

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Howard.J.Bampton at Motorola.co
                   |                            |m



------- Additional Comments From dtucker at zip.com.au  2003-10-09 01:02 -------
*** Bug 735 has been marked as a duplicate of this bug. ***



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.