openssh bugs - Sep 2003 - [Bug 668] ssh truncates long banner message

http://bugzilla.mindrot.org/show_bug.cgi?id=668

           Summary: ssh truncates long banner message
           Product: Portable OpenSSH
           Version: 3.7p1
          Platform: Sparc
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ssh
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: dpb at bl.com


I have a long, 1184 bytes, banner file. It is the one that Titan installs. and 
with the 3.6 version of ssh it prints fine. With the 3.7 version only part of 
it prints.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dpb at bl.com  2003-09-18 07:01 -------
Created an attachment (id=418)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=418&action=view)
The offending banner file




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dtucker at zip.com.au  2003-09-18 11:00 -------
Created an attachment (id=419)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=419&action=view)
Don't use logit() for banner

How about something like the attached patch?  (WARNING: almost entirely
untested)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dpb at bl.com  2003-09-18 12:57 -------
Works for me, almost. I didn't need a blank line at the bottom of the banner
file before. The login message appears on the same line as the last line in the
file. If there is a blank line on the bottom everything appears the same. Now 
that I know where to look the new code is the same as the old 3.6p2 code. The 
newline must have come from elsewhere.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dtucker at zip.com.au  2003-09-18 13:59 -------
Just change sshconnect2.c line 369 from
fprintf(stderr, "%s", fmtbuf);
to
fprintf(stderr, "%s\n", fmtbuf);



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From djm at mindrot.org  2003-09-18 17:26 -------
Hang on, that undoes the fix for bug #225





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #419 is|0                           |1
           obsolete|                            |



------- Additional Comments From dtucker at zip.com.au  2003-09-18 17:37 -------
Created an attachment (id=421)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=421&action=view)
check options.loglevel and use fprintf

Damn, you're right.  I thought that looked strangely familiar.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dpb at bl.com  2003-09-19 06:51 -------
It is now a perfect fix, thank you.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2003-10-07 16:44 -------
This has now been fixed in OpenBSD, it will appear in Portable's snapshots
shortly.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668

dpb at bl.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From dpb at bl.com  2003-10-10 00:44 -------
I found one problem with the fix. If there is a banner file defined at the 
target system and it does not exist or is zero length the ssh command will fail 
with ax "malloc: zero size" error.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dpb at bl.com  2003-10-10 01:15 -------
Another problem with 3.7.1p2 and banners, the banner ends with an extra cr and 
not a crnl



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From markus at openbsd.org  2003-10-10 04:29 -------
who is printing: "malloc: zero size"?

this would be a different bug.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dtucker at zip.com.au  2003-10-10 11:50 -------
I added some regression tests with the the fix, including a test of a zero-
length banner file and I haven't seen the malloc error you reported.  Please
open a new bug and attach the output of "ssh -vvv" showing the
problem.

The extra CR thing is also fixed by patch id #421.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668





------- Additional Comments From dpb at bl.com  2003-10-10 12:36 -------
Created an attachment (id=479)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=479&action=view)
Trace of ssh -vvv




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=668

dpb at bl.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dpb at bl.com  2003-10-10 13:21 -------
Error at this end. Somehow the patch was reverted to an older version. Sorry to 
have bothered you.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.