xen discuss - Aug 2008 - Reviews for 6742301 virsh dump isn''t working properly

http://cr.opensolaris.org/~johnlev/dump-core-fixes/

thanks!

john

On Fri, Aug 29, 2008 at 02:01:00AM +0100, John Levon wrote:
> http://cr.opensolaris.org/~johnlev/dump-core-fixes/
Ping for willing volunteers :)

john

John Levon wrote:
> On Fri, Aug 29, 2008 at 02:01:00AM +0100, John Levon wrote:
> 
>> http://cr.opensolaris.org/~johnlev/dump-core-fixes/
Am I missing something, or does the change in libvirt actually have no 
effect?  It seems like the live parameter is ignored once you get into 
domain_dump.

-Ryan
> 
> Ping for willing volunteers :)
> 
> john
> _______________________________________________
> xen-discuss mailing list
> xen-discuss@opensolaris.org

On Thu, Sep 04, 2008 at 03:42:13PM -0700, Ryan Scott wrote:
> >On Fri, Aug 29, 2008 at 02:01:00AM +0100, John Levon wrote:
> >
> >>http://cr.opensolaris.org/~johnlev/dump-core-fixes/
> 
> Am I missing something, or does the change in libvirt actually have no 
> effect?  It seems like the live parameter is ignored once you get into 
> domain_dump.
You''re right. Wow that''s stupid code. I''ll fix up my
bug description (it
still stands, but doesn''t really change much). I''ll also think
about
making it pause the domain by default.

regards
john

On Fri, Aug 29, 2008 at 02:01:00AM +0100, John Levon wrote:
> http://cr.opensolaris.org/~johnlev/dump-core-fixes/
Now updated with a new version that implements the live/crash options
properly.

regards
john

John Levon wrote:
> On Fri, Aug 29, 2008 at 02:01:00AM +0100, John Levon wrote:
> 
>> http://cr.opensolaris.org/~johnlev/dump-core-fixes/
> 
> Now updated with a new version that implements the live/crash options
> properly.
Looks good to me.

-Ryan
> 
> regards
> john
> _______________________________________________
> xen-discuss mailing list
> xen-discuss@opensolaris.org