xen discuss - Aug 2008 - snv_96: dladm output format change, breaks xvm vif-vnic script

Is there already a bug filed for the problem that the putback for
"PSARC/2008/374 dladm parseable output", onnv-gate changeset 7158,
once again changed the output format of "dladm show-link -p",
breaking xVM''s /usr/lib/xen/scripts/vif-vnic script?

All I found is 6722523, which mentions that xVM is a consumer
of the dladm output.


the snv_95 version of vif-vnic fails like this, under snv_96:

...
+ mktemp
goodlinks=/tmp/tmp.E8aq6b
+ mktemp
badlinks=/tmp/tmp.K8ay6b
+ [ -z /tmp/tmp.E8aq6b -o -z /tmp/tmp.K8ay6b ]
+ read i
+ dladm show-link -p
dladm: -p requires -o+ eval


Suggested fix:
=============
diff --git a/src/scripts/vif-vnic b/src/scripts/vif-vnic
--- a/src/scripts/vif-vnic
+++ b/src/scripts/vif-vnic
@@ -78,8 +78,7 @@
 			fail_connect
 		fi
 
-		dladm show-link -p | while read i; do
-			eval $i
+		dladm show-link -p -o LINK,STATE | while IFS=: read LINK STATE; 
do
 			if [ "$STATE" = "up" ]; then
 				echo $LINK >>$goodlinks
 			else
 
 
This message posted from opensolaris.org

On Mon, Aug 04, 2008 at 02:15:47AM -0700, J??rgen Keil
wrote:
> Is there already a bug filed for the problem that the putback for
> "PSARC/2008/374 dladm parseable output", onnv-gate changeset
7158,
> once again changed the output format of "dladm show-link -p",
> breaking xVM''s /usr/lib/xen/scripts/vif-vnic script?
A fix went into xvm-gate on 22nd July.

Jürgen Keil wrote:
> Is there already a bug filed for the problem that the putback for
> "PSARC/2008/374 dladm parseable output", onnv-gate changeset
7158,
> once again changed the output format of "dladm show-link -p",
> breaking xVM''s /usr/lib/xen/scripts/vif-vnic script?
> 
> All I found is 6722523, which mentions that xVM is a consumer
> of the dladm output.
I put back the fix in vif-vnic at the same time as I put back the changes 
to dladm.
You did see the heads-up message to keep the bits in sync, right? ;-)

michael
> All,
> 
> the putback of
> 
> 6722523 dladm needs a robust and convenient parsable output mode
> 
> constitutes a flag day for users of xVM on Solaris: 
[...]

-- 
Michael Schuster 	http://blogs.sun.com/recursion
Recursion, n.: see ''Recursion''

Michael Schuster wrote:
> Jürgen Keil wrote:
> > Is there already a bug filed for the problem that the putback for
> > "PSARC/2008/374 dladm parseable output", onnv-gate changeset
7158,
> > once again changed the output format of "dladm show-link
-p",
> > breaking xVM's /usr/lib/xen/scripts/vif-vnic script?
> > 
> I put back the fix in vif-vnic at the same time as I put back the changes
to dladm.
> You did see the heads-up message to keep the bits in sync, right? ;-)
No, I didn't see it.  At least not on the web site:

http://www.opensolaris.org/os/community/on/flag-days/96-00/
http://www.opensolaris.org/os/community/on/flag-days/91-95/

There are no Build 96 heads-up messages referenced between
Jul-22 and Jul-29...  

But google did find it, here:

http://www.opensolaris.org/os/community/on/flag-days/pages/2008072201/
 
 
This message posted from opensolaris.org
_______________________________________________
xen-discuss mailing list
xen-discuss@opensolaris.org