xen discuss - Jul 2007 - possible bug in xen.hg/tools/ioemu/tools/vl.c, function net_tap_init()

in xen.hg/tools/ioemu/tools/vl.c, function net_tap_init()


        if (need_setphysaddr) {
                if ((r = dlpi_set_physaddr(dh, DL_CURR_PHYS_ADDR,
                         s->mac_addr, ETHERADDRL)) != DLPI_SUCCESS) {
                        fprintf(logfile,
                            "net_tap_init: cannot set physaddr
(%d)\n",
                            r);
                        ret = -1;
                        goto done;
                }
        }


Shouldn''t dlpi_set_physaddr() be called with "mac_addr"
instead of
"s->mac_addr" ? 

The "s" pointer should point to NULL at this point, so I guess qemu-dm
would either crash or use some random binary junk block as mac
address...
 
 
This message posted from opensolaris.org

Jürgen Keil wrote:
> in xen.hg/tools/ioemu/tools/vl.c, function net_tap_init()
> 
> 
>         if (need_setphysaddr) {
>                 if ((r = dlpi_set_physaddr(dh, DL_CURR_PHYS_ADDR,
>                          s->mac_addr, ETHERADDRL)) != DLPI_SUCCESS) {
>                         fprintf(logfile,
>                             "net_tap_init: cannot set physaddr
(%d)\n",
>                             r);
>                         ret = -1;
>                         goto done;
>                 }
>         }
> 
> 
> Shouldn''t dlpi_set_physaddr() be called with "mac_addr"
instead of
> "s->mac_addr" ? 
Yes. I''ll file a bug.

dme.

On Mon, Jul 30, 2007 at 11:55:13PM +0100, David Edmondson
wrote:
> Jrgen Keil wrote:
> > in xen.hg/tools/ioemu/tools/vl.c, function net_tap_init()
> > 
> > 
> >         if (need_setphysaddr) {
> >                 if ((r = dlpi_set_physaddr(dh, DL_CURR_PHYS_ADDR,
> >                          s->mac_addr, ETHERADDRL)) != DLPI_SUCCESS)
{
> >                         fprintf(logfile,
> >                             "net_tap_init: cannot set physaddr
(%d)\n",
> >                             r);
> >                         ret = -1;
> >                         goto done;
> >                 }
> >         }
> > 
> > 
> > Shouldn''t dlpi_set_physaddr() be called with
"mac_addr" instead of
> > "s->mac_addr" ? 
> 
> Yes. I''ll file a bug.
6588683

dme.