ogg.k.ogg.k at googlemail.com
2008-Dec-16 21:09 UTC
[ogg-dev] liboggz: use ogg_int64_t instead of C99 int64_t for the benefit of you-can-guess-who
A widely used platform doesn't bother to have C99 integer types, so this allows building with it. Reported by sirlemonhead on IRC. Index: src/tools/oggz_tools.c ==================================================================--- src/tools/oggz_tools.c (revision 3827) +++ src/tools/oggz_tools.c (working copy) @@ -450,7 +450,7 @@ dg->pt = (iframe + pframe) >> 9; dg->dist = ((iframe & 0xff) << 8) | (pframe & 0xff); dg->delay = pframe >> 9; - dg->dt = (int64_t)dg->pt - dg->delay; + dg->dt = (ogg_int64_t)dg->pt - dg->delay; } int Index: src/liboggz/metric_internal.c ==================================================================--- src/liboggz/metric_internal.c (revision 3827) +++ src/liboggz/metric_internal.c (working copy) @@ -53,7 +53,7 @@ pframe = granulepos - (iframe << stream->granuleshift); pt = (iframe + pframe) >> 9; delay = pframe >> 9; - dt = (int64_t)pt - delay; + dt = (ogg_int64_t)pt - delay; units = dt * stream->granulerate_d / stream->granulerate_n;
Ralph Giles
2008-Dec-16 21:24 UTC
[ogg-dev] liboggz: use ogg_int64_t instead of C99 int64_t for the benefit of you-can-guess-who
On Tue, Dec 16, 2008 at 1:09 PM, ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com> wrote:> A widely used platform doesn't bother to have C99 > integer types, so this allows building with it.Since these are the only two uses of int64_t instead of ogg_int64_t in liboggz, please commit. -r
Erik de Castro Lopo
2008-Dec-16 21:29 UTC
[ogg-dev] liboggz: use ogg_int64_t instead of C99 int64_t for the benefit of you-can-guess-who
ogg.k.ogg.k at googlemail.com wrote:> A widely used platform doesn't bother to have C99 > integer types, so this allows building with it.Its not the platform, just the most common compiler on that platform. GCC and the Intel compiler (with the -c99 switch) on windows both have int64_t :-). In fact both compilers are mostly C99 compliant. Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "Using Java as a general purpose application development language is like going big game hunting armed with Nerf weapons." -- Author Unknown
ogg.k.ogg.k at googlemail.com
2008-Dec-16 21:30 UTC
[ogg-dev] liboggz: use ogg_int64_t instead of C99 int64_t for the benefit of you-can-guess-who
> Since these are the only two uses of int64_t instead of ogg_int64_t in > liboggz, please commit.In svn. Didn't get the OK from Conrad from committing to his software, hope it's OK kfish ^_^