ogg dev - Jun 2008 - [PATCH] browser_plugin - kate support, build fixes, and misc

>> hmm, perhaps we should add some configure arguments like
>> --with-firefox-cflags= and --with-firefox-libs>
> I've made it a single one, --with-gecko-sdk= and also default
> include path and xpidl path to that if specified.
Hi,

I noticed this hasn't been applied, so I'm sending it again as it's
quite simple
and, I think, unobtrusive.
It allows building against a prebuilt Gecko SDK.
If it needs changing to be applied, feel free to tell me what you'd
like changed.

Cheers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browser_plugin-with-gecko-sdk.diff
Type: text/x-patch
Size: 1697 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/ogg-dev/attachments/20080602/500f9bfe/attachment.bin

2008/6/2 ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at
googlemail.com>:
>>> hmm, perhaps we should add some configure arguments like
>>> --with-firefox-cflags= and --with-firefox-libs>>
>> I've made it a single one, --with-gecko-sdk= and also default
>> include path and xpidl path to that if specified.
>
> Hi,
>
> I noticed this hasn't been applied, so I'm sending it again as
it's quite simple
> and, I think, unobtrusive.
Ah, very sorry -- when I came back to this email thread I thought it
concerned an earlier Kate patch, not the more recent build fixes.
> It allows building against a prebuilt Gecko SDK.
applied in changeset:3605

Conrad.

> Ah, very sorry -- when I came back to this email thread I thought it
> concerned an earlier Kate patch, not the more recent build fixes.
>
>> It allows building against a prebuilt Gecko SDK.
>
> applied in changeset:3605
No worries, thanks again for your time!