ogg.k.ogg.k at googlemail.com
2008-May-01 09:59 UTC
[ogg-dev] [PATCH] liboggplay - kate support, build fixes, and misc
> There seems to be some inconsistency in the changes to the type of > sample_in_record and its accessor: the field was changed from int to > ogg_int64_t in src/liboggplay/oggplay_callback_info.h, and the return > type of the accessor function was changed from int to long in the > corresponding .c file and public header.Having heard no more about this, I'll make a patch that returns ogg_int64_t, and hope Python likes it, is it OK ?
Conrad Parker
2008-May-01 11:32 UTC
[ogg-dev] [PATCH] liboggplay - kate support, build fixes, and misc
2008/5/1 ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com>:> > There seems to be some inconsistency in the changes to the type of > > sample_in_record and its accessor: the field was changed from int to > > ogg_int64_t in src/liboggplay/oggplay_callback_info.h, and the return > > type of the accessor function was changed from int to long in the > > corresponding .c file and public header. > > Having heard no more about this, I'll make a patch that returns ogg_int64_t, > and hope Python likes it, is it OK ?I'll be happy with that -- there are other functions which expose ogg_int64_t also, so I assume it's ok ... Conrad.
ogg.k.ogg.k at googlemail.com
2008-May-01 11:39 UTC
[ogg-dev] [PATCH] liboggplay - kate support, build fixes, and misc
> I'll be happy with that -- there are other functions which expose > ogg_int64_t also, so I assume it's ok ...Oh ? Ahem. I need to check more thoroughly next time. :) I'll try to post that tomorrow. thanks