Dzianis Kahanovich
2012-Jul-26 13:37 UTC
[Ocfs2-users] ocfs2-tools git: broken after commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e
ocfs2-tools git wrong commit: deb5ade9145f8809f1fde19cf53bdfdf1fb7963e.
After "cleanup unused variable":
- else
- tmp = g_list_append(elem, cfs);
o2cb_ctl starts to ignore >1 node. Good commit must be:
else
- tmp = g_list_append(elem, cfs);
+ g_list_append(elem, cfs);
Attached patch.
--
WBR, Dzianis Kahanovich AKA Denis Kaganovich, http://mahatma.bspu.unibel.by/
-------------- next part --------------
Partial revert of commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e
Fixed o2cb_ctl ignoring >1 node.
Signed-off-by: Denis Kaganovich (Dzianis Kahanovich) <mahatma at eu.by>
diff -pruN a/o2cb_ctl/jconfig.c b/o2cb_ctl/jconfig.c
--- a/o2cb_ctl/jconfig.c 2012-03-14 21:45:05.000000000 +0300
+++ b/o2cb_ctl/jconfig.c 2012-07-26 16:06:38.000000000 +0300
@@ -1082,6 +1082,8 @@ JConfigStanza *j_config_add_stanza(JConf
g_strdup(stanza_name),
elem);
}
+ else
+ g_list_append(elem, cfs);
return(cfs);
} /* j_config_add_stanza() */
Sunil Mushran
2012-Jul-26 17:31 UTC
[Ocfs2-users] ocfs2-tools git: broken after commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e
On Thu, Jul 26, 2012 at 6:37 AM, Dzianis Kahanovich <mahatma at bspu.unibel.by>wrote:> ocfs2-tools git wrong commit: deb5ade9145f8809f1fde19cf53bdfdf1fb7963e. > > After "cleanup unused variable": > - else > - tmp = g_list_append(elem, cfs); > > o2cb_ctl starts to ignore >1 node. Good commit must be: > else > - tmp = g_list_append(elem, cfs); > + g_list_append(elem, cfs); > > Attached patch. > >Thanks. Acked-by: Sunil Mushran <sunil.mushran at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://oss.oracle.com/pipermail/ocfs2-users/attachments/20120726/76c5636f/attachment.html