Ocfs2 users - Oct 2011 - indexed tree failed while enable indexed-dirs

OCFS2 1.6

tunefs.ocfs2 -v --fs-features 
backup-super,discontig-bg,sparse,inline-data,unwritten,indexed-dirs ${vol}

Enabling feature "sparse_files"
Enabling feature "backup_super"
Enabling feature "unwritten_extents"
Enabling feature "inline_data"
Enabling feature "indexed_dirs"
Enabling feature "discontig_bg"
Sat Oct 15 18:28:14 PDT 2011
Sat Oct 15 18:33:14 PDT 2011
Sat Oct 15 18:38:14 PDT 2011
Sat Oct 15 18:43:14 PDT 2011
Backup superblock feature is already enabled; nothing to enable
tunefs.ocfs2: Build directory indexed tree failed while enable indexed-dirs
tunefs.ocfs2: Build directory indexed tree failed while building indexed 
trees

But, strangely, indexed-dirs is reported as enabled, whereas 
discontig-bg, which did not send any warning, is not:

tunefs.ocfs2 -Q "Compat: %M\nIncompat: %H\nRO Compat: %O\n" ${vol}
Compat: backup-super
Incompat: sparse inline-data indexed-dirs
RO Compat: unwritten

On the same volume, I re-run the same command without indexed-dirs. This 
was the output:

tunefs.ocfs2 -v --fs-features 
backup-super,discontig-bg,sparse,inline-data,unwritten ${vol}
Enabling feature "sparse_files"
Enabling feature "backup_super"
Enabling feature "unwritten_extents"
Enabling feature "inline_data"
Enabling feature "discontig_bg"
Sparse file feature is already enabled; nothing to enable Backup 
superblock feature is already enabled; nothing to enable Unwritten 
extents feature is already enabled; nothing to enable The inline data 
feature is already enabled; nothing to enable

And here's the status report:

Compat: backup-super
Incompat: sparse inline-data indexed-dirs discontig-bg
RO Compat: unwritten

indexed-dirs is still reported even though it was not included in the 
last reconfig command, and discontig-bg is finally enabled.

Could someone help me make sense out of this? Was indexed-dirs enabled 
the first time around, even though it reported failure? Why was 
discontig-bg not enabled the first time, yet it did not report anything 
wrong? And then, second attempt, why indexed-dirs remained "enabled" 
even though I did not specify it? And is it truly enabled now?

-- 
Florin Andrei
http://florin.myip.org/

On Mon, Oct 17, 2011 at 2:28 PM, Florin Andrei <florin at andrei.myip.org>
wrote:
> OCFS2 1.6
>
> tunefs.ocfs2 -v --fs-features
> backup-super,discontig-bg,sparse,inline-data,unwritten,indexed-dirs ${vol}
>
> Enabling feature "sparse_files"
> Enabling feature "backup_super"
> Enabling feature "unwritten_extents"
> Enabling feature "inline_data"
> Enabling feature "indexed_dirs"
> Enabling feature "discontig_bg"
> Sat Oct 15 18:28:14 PDT 2011
> Sat Oct 15 18:33:14 PDT 2011
> Sat Oct 15 18:38:14 PDT 2011
> Sat Oct 15 18:43:14 PDT 2011
> Backup superblock feature is already enabled; nothing to enable
> tunefs.ocfs2: Build directory indexed tree failed while enable indexed-dirs
> tunefs.ocfs2: Build directory indexed tree failed while building indexed
> trees
>
> But, strangely, indexed-dirs is reported as enabled, whereas
> discontig-bg, which did not send any warning, is not:
>
> tunefs.ocfs2 -Q "Compat: %M\nIncompat: %H\nRO Compat: %O\n"
${vol}
> Compat: backup-super
> Incompat: sparse inline-data indexed-dirs
> RO Compat: unwritten
>
> On the same volume, I re-run the same command without indexed-dirs. This
> was the output:
>
> tunefs.ocfs2 -v --fs-features
> backup-super,discontig-bg,sparse,inline-data,unwritten ${vol}
> Enabling feature "sparse_files"
> Enabling feature "backup_super"
> Enabling feature "unwritten_extents"
> Enabling feature "inline_data"
> Enabling feature "discontig_bg"
> Sparse file feature is already enabled; nothing to enable Backup
> superblock feature is already enabled; nothing to enable Unwritten
> extents feature is already enabled; nothing to enable The inline data
> feature is already enabled; nothing to enable
>
> And here's the status report:
>
> Compat: backup-super
> Incompat: sparse inline-data indexed-dirs discontig-bg
> RO Compat: unwritten
>
> indexed-dirs is still reported even though it was not included in the
> last reconfig command, and discontig-bg is finally enabled.
>
> Could someone help me make sense out of this? Was indexed-dirs enabled
> the first time around, even though it reported failure?
Yes, partially. The indexed-dirs feature is supposed to build indexed
of all the directories, but it bailed out because it encountered an
error. So, for the directories for which indexed directories were not
enabled (and the ones following that), indexing will not be used.
However, it is enabled in the superblock.

> Why was
> discontig-bg not enabled the first time, yet it did not report anything
> wrong?
Because it was scheduled after indexed-dirs. However, indexed-dirs
failed and the tool bailed out.

And then, second attempt, why indexed-dirs remained
"enabled"
> even though I did not specify it?
Because it was partially successful the first time. It managed to put
it in the superblock. In order to disable it, you must specify
noindexed-dirs
> And is it truly enabled now?
Yes. However, some directories are not indexed. I have posted fsck
patches which would fix this, but it is still in review.

-- 
Goldwyn