Christoph Hellwig
2023-Mar-10 06:37 UTC
[Ocfs2-devel] [PATCH 1/3] ufs: don't flush page immediately for DIRSYNC directories
On Fri, Mar 10, 2023 at 03:53:53AM +0000, Al Viro wrote:> On Tue, Mar 07, 2023 at 03:31:23PM +0100, Christoph Hellwig wrote: > > We do not need to writeout modified directory blocks immediately when > > modifying them while the page is locked. It is enough to do the flush > > somewhat later which has the added benefit that inode times can be > > flushed as well. It also allows us to stop depending on > > write_one_page() function. > > > > Ported from an ext2 patch by Jan Kara. > > Umm... I'll throw it in ufs pile, I guess (tomorrow - I'll need to > sort out Fabio's patches in the area as well; IIRC, the latest > had been in late December).Well, the three patches really should go together, otherwise we miss yet another merge window.
Al Viro
2023-Mar-10 06:52 UTC
[Ocfs2-devel] [PATCH 1/3] ufs: don't flush page immediately for DIRSYNC directories
On Fri, Mar 10, 2023 at 07:37:56AM +0100, Christoph Hellwig wrote:> On Fri, Mar 10, 2023 at 03:53:53AM +0000, Al Viro wrote: > > On Tue, Mar 07, 2023 at 03:31:23PM +0100, Christoph Hellwig wrote: > > > We do not need to writeout modified directory blocks immediately when > > > modifying them while the page is locked. It is enough to do the flush > > > somewhat later which has the added benefit that inode times can be > > > flushed as well. It also allows us to stop depending on > > > write_one_page() function. > > > > > > Ported from an ext2 patch by Jan Kara. > > > > Umm... I'll throw it in ufs pile, I guess (tomorrow - I'll need to > > sort out Fabio's patches in the area as well; IIRC, the latest > > had been in late December). > > Well, the three patches really should go together, otherwise we miss > yet another merge window.Umm... Do you need them in the same (never-rebased?) branch, or would it suffice to have all of them reach mainline by 6.4-rc1?