Andrew Morton
2023-Mar-07 21:39 UTC
[Ocfs2-devel] + ocfs2-dont-use-write_one_page-in-ocfs2_duplicate_clusters_by_page.patch added to mm-unstable branch
The patch titled Subject: ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page has been added to the -mm mm-unstable branch. Its filename is ocfs2-dont-use-write_one_page-in-ocfs2_duplicate_clusters_by_page.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/ocfs2-dont-use-write_one_page-in-ocfs2_duplicate_clusters_by_page.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Christoph Hellwig <hch at lst.de> Subject: ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page Date: Tue, 7 Mar 2023 15:31:24 +0100 Use filemap_write_and_wait_range to write back the range of the dirty page instead of write_one_page in preparation of removing write_one_page and eventually ->writepage. Link: https://lkml.kernel.org/r/20230307143125.27778-3-hch at lst.de Signed-off-by: Christoph Hellwig <hch at lst.de> Reviewed-by: Jan Kara <jack at suse.cz> Reviewed-by: Joseph Qi <joseph.qi at linux.alibaba.com> Cc: Changwei Ge <gechangwei at live.cn> Cc: Dave Kleikamp <dave.kleikamp at oracle.com> Cc: Evgeniy Dushistov <dushistov at mail.ru> Cc: Gang He <ghe at suse.com> Cc: Jan Kara via Ocfs2-devel <ocfs2-devel at oss.oracle.com> Cc: Joel Becker <jlbec at evilplan.org> Cc: Joseph Qi <jiangqi903 at gmail.com> Cc: Jun Piao <piaojun at huawei.com> Cc: Junxiao Bi <junxiao.bi at oracle.com> Cc: Mark Fasheh <mark at fasheh.com> Cc: Matthew Wilcox (Oracle) <willy at infradead.org> Signed-off-by: Andrew Morton <akpm at linux-foundation.org> --- fs/ocfs2/refcounttree.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/fs/ocfs2/refcounttree.c~ocfs2-dont-use-write_one_page-in-ocfs2_duplicate_clusters_by_page +++ a/fs/ocfs2/refcounttree.c @@ -2952,10 +2952,11 @@ retry: */ if (PAGE_SIZE <= OCFS2_SB(sb)->s_clustersize) { if (PageDirty(page)) { - /* - * write_on_page will unlock the page on return - */ - ret = write_one_page(page); + unlock_page(page); + put_page(page); + + ret = filemap_write_and_wait_range(mapping, + offset, map_end - 1); goto retry; } } _ Patches currently in -mm which might be from hch at lst.de are ufs-dont-flush-page-immediately-for-dirsync-directories.patch ocfs2-dont-use-write_one_page-in-ocfs2_duplicate_clusters_by_page.patch mmjfs-move-write_one_page-folio_write_one-to-jfs.patch
Seemingly Similar Threads
- [PATCH 2/3] ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page
- + ufs-dont-flush-page-immediately-for-dirsync-directories.patch added to mm-unstable branch
- remove most callers of write_one_page v4
- remove most callers of write_one_page v3
- [PATCH] ocfs2: Don't duplicate page passes i_size during CoW.