Shuah Khan
2022-Nov-21 21:43 UTC
[Ocfs2-devel] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
On 11/21/22 14:40, Shuah Khan wrote:> On 11/21/22 07:34, Benjamin Coddington wrote: >> On 21 Nov 2022, at 8:56, David Howells wrote: >> >>> Benjamin Coddington <bcodding at redhat.com> wrote: >>> >>>> Since moving to memalloc_nofs_save/restore, SUNRPC has stopped setting the >>>> GFP_NOIO flag on sk_allocation which the networking system uses to decide >>>> when it is safe to use current->task_frag. >>> >>> Um, what's task_frag? >> >> Its a per-task page_frag used to coalesce small writes for networking -- see: >> >> 5640f7685831 net: use a per task frag allocator >> >> Ben >> >> > > I am not seeing this in the mainline. Where can find this commit? >Okay. I see this commit in the mainline. However, I don't see the sk_use_task_frag in mainline. thanks, -- Shuah
Benjamin Coddington
2022-Nov-21 22:01 UTC
[Ocfs2-devel] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
On 21 Nov 2022, at 16:43, Shuah Khan wrote:> On 11/21/22 14:40, Shuah Khan wrote: >> On 11/21/22 07:34, Benjamin Coddington wrote: >>> On 21 Nov 2022, at 8:56, David Howells wrote: >>> >>>> Benjamin Coddington <bcodding at redhat.com> wrote: >>>> >>>>> Since moving to memalloc_nofs_save/restore, SUNRPC has stopped setting the >>>>> GFP_NOIO flag on sk_allocation which the networking system uses to decide >>>>> when it is safe to use current->task_frag. >>>> >>>> Um, what's task_frag? >>> >>> Its a per-task page_frag used to coalesce small writes for networking -- see: >>> >>> 5640f7685831 net: use a per task frag allocator >>> >>> Ben >>> >>> >> >> I am not seeing this in the mainline. Where can find this commit? >> > > Okay. I see this commit in the mainline. However, I don't see the > sk_use_task_frag in mainline.sk_use_task_frag is in patch 1/3 in this posting. https://lore.kernel.org/netdev/26d98c8f-372b-b9c8-c29f-096cddaff149 at linuxfoundation.org/T/#m3271959c4cf8dcff1c0c6ba023b2b3821d9e7e99 Ben