Ocfs2 devel - Nov 2022 - dinode link count inconsistency in ocfs2_read_links_count() logic

The modification I mentioned surely fixes the thing (well, obviously).

If to reproduce, trivial as well:

- mkfs with indexed-dirs option (otherwise low hardlink limit will apply)
- Create a file
- Create 65535 hardlinks to it, stat will now show 65536 hardlinks (that 
comes from local inode cache)
- Clear inode cache (for me cat 3 > /proc/sys/vm/drop_caches is enough) 
or reboot
- stat again and you will see hardlink count = 0 that is the result of 
actual inconsistency

On 11/22/22 12:15 AM, Alexey Asemov (Alex/AT) via Ocfs2-devel
wrote:
> The modification I mentioned surely fixes the thing (well, obviously).
> 
> If to reproduce, trivial as well:
> 
> - mkfs with indexed-dirs option (otherwise low hardlink limit will apply)
> - Create a file
> - Create 65535 hardlinks to it, stat will now show 65536 hardlinks (that
comes from local inode cache)
> - Clear inode cache (for me cat 3 > /proc/sys/vm/drop_caches is enough)
or reboot
> - stat again and you will see hardlink count = 0 that is the result of
actual inconsistency
> 
Will take a deep look into it.

Thanks,
Joseph