Geert Uytterhoeven
2018-Aug-23 21:07 UTC
[Ocfs2-devel] [PATCH] fs/ocfs2/dlmglue: lockdep_keys defined but not used
Hi Anders, On Wed, Jul 4, 2018 at 11:54 AM Anders Roxell <anders.roxell at linaro.org> wrote:> When CONFIG_DEBUG_LOCK_ALLOC isn't enabled lockdep_keys isn't used and > we get a warning: > fs/ocfs2/dlmglue.c:99:30: warning: ?lockdep_keys? defined but not used > [-Wunused-variable] > static struct lock_class_key lockdep_keys[OCFS2_NUM_LOCK_TYPES]; > ^~~~~~~~~~~~ > Adding __maybe_unused to the declaration hids the warning.Thanks for your patcj!> Fixes: 1cd75cdb8fbb ("ocfs2: make several functions and variables static (and some const)")Fixes: 480bd56485b77c36 ("ocfs2: make several functions and variables static (and some const)") Presumably the branch got rebased?> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>Acked-by: Geert Uytterhoeven <geert at linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds