Ocfs2 devel - Feb 2018 - [PATCH] ocfs2/dlm: clean unrelated comment

From: Changwei Ge <ge.changwei at h3c.com>

Obviously, the comment before dlm_do_local_recovery_cleanup() has
nothing to do with it. So remove it.

Signed-off-by: Changwei Ge <ge.changwei at h3c.com>
---
 fs/ocfs2/dlm/dlmrecovery.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index ec8f758..65f0c54 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
 	__dlm_dirty_lockres(dlm, res);
 }
 
-/* if this node is the recovery master, and there are no
- * locks for a given lockres owned by this node that are in
- * either PR or EX mode, zero out the lvb before requesting.
- *
- */
-
-
 static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
 {
 	struct dlm_lock_resource *res;
-- 
2.7.4

Hi changwei,

On 2018/2/23 15:30, ge.changwei at h3c.com wrote:
> From: Changwei Ge <ge.changwei at h3c.com>
This line seems unnecessary, others looks good to me.

thanks,
Jun
> 
> Obviously, the comment before dlm_do_local_recovery_cleanup() has
> nothing to do with it. So remove it.
> 
> Signed-off-by: Changwei Ge <ge.changwei at h3c.com>
> ---
>  fs/ocfs2/dlm/dlmrecovery.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index ec8f758..65f0c54 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt
*dlm,
>  	__dlm_dirty_lockres(dlm, res);
>  }
>  
> -/* if this node is the recovery master, and there are no
> - * locks for a given lockres owned by this node that are in
> - * either PR or EX mode, zero out the lvb before requesting.
> - *
> - */
> -
> -
>  static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8
dead_node)
>  {
>  	struct dlm_lock_resource *res;
>

On 18/2/23 15:30, ge.changwei at h3c.com wrote:
> From: Changwei Ge <ge.changwei at h3c.com>
> 
> Obviously, the comment before dlm_do_local_recovery_cleanup() has
> nothing to do with it. So remove it.
> 
> Signed-off-by: Changwei Ge <ge.changwei at h3c.com>
It seems to say we can no longer trust the lvb in this case. Maybe it
should be placed somewhere to call dlm_revalidate_lvb()?

Anyway, this cleanup looks good to me.
Acked-by: Joseph Qi <jiangqi903 at gmail.com>