Jan Kara
2017-Jun-19 08:50 UTC
[Ocfs2-devel] [PATCH 23/28] mbcache: make mbcache more generic
On Thu 15-06-17 11:25:02, Tahsin Erdogan wrote:> On Thu, Jun 15, 2017 at 12:41 AM, Jan Kara <jack at suse.cz> wrote: > > Can you explain a bit more what do you mean by "make it more generic" as it > > seems you just rename a couple of things here... > > The change is really just that, having names that are more generic > which do not limit use cases to block sharing. In a subsequent patch > in the series ("[PATCH v4 27/28] ext4: xattr inode deduplication"), we > start using the mbcache code to share xattr inodes. With that patch, > old mb_cache_entry.e_block field could be holding either a block > number or an inode number, so I renamed things to make them more > generic.OK, then I'd suggest to change title to "mbcache: make mbcache naming more generic" and explain what you wrote here in the changelog. Thanks! Honza -- Jan Kara <jack at suse.com> SUSE Labs, CR