piaojun
2016-Mar-14 12:41 UTC
[Ocfs2-devel] [PATCH V2] ocfs2/dlm: fix a variable overflow problem in dlmdomain.c
In dlm_send_join_cancels(), node is defined with type unsigned int, but initialized with -1, this will lead variable overflow. Although this won't cause any runtime problem, the code looks a little uncoordinated. Signed-off-by: Jun Piao <piaojun at huawei.com> --- dlm/dlmdomain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c index 2ee7fe7..8cbf6e8 100644 --- a/dlm/dlmdomain.c +++ b/dlm/dlmdomain.c @@ -1396,7 +1396,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm, unsigned int map_size) { int status, tmpstat; - unsigned int node; + int node; if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) * sizeof(unsigned long))) { -- 1.8.4.3
Joseph Qi
2016-Mar-14 12:46 UTC
[Ocfs2-devel] [PATCH V2] ocfs2/dlm: fix a variable overflow problem in dlmdomain.c
On 2016/3/14 20:41, piaojun wrote:> In dlm_send_join_cancels(), node is defined with type unsigned int, but > initialized with -1, this will lead variable overflow. Although this > won't cause any runtime problem, the code looks a little uncoordinated. > > Signed-off-by: Jun Piao <piaojun at huawei.com>Thanks, Jun. Reviewed-by: Joseph Qi <joseph.qi at huawei.com>> --- > dlm/dlmdomain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c > index 2ee7fe7..8cbf6e8 100644 > --- a/dlm/dlmdomain.c > +++ b/dlm/dlmdomain.c > @@ -1396,7 +1396,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm, > unsigned int map_size) > { > int status, tmpstat; > - unsigned int node; > + int node; > > if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) * > sizeof(unsigned long))) { >